Two tests in wpt/credential-management started to crash recently |
||||
Issue descriptioncredential-management/federatedcredential-framed-get.sub.https.html Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcredential-management%2Ffederatedcredential-framed-get.sub.https.html credential-management/passwordcredential-framed-get.sub.https.html Dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcredential-management%2Fpasswordcredential-framed-get.sub.https.html Both tests crash quite consistently on all three platforms.
,
Dec 22 2017
engedy@,kpaulhamus@: Mind taking a look at this?
,
Dec 22 2017
Looks like it's hitting a DCHECK: """ [8355:8556:1221/145648.154587:FATAL:service_manager.cc(154)] Check failed: false. The Service Manager prevented service "content_renderer" from binding interface "password_manager::mojom::CredentialManager" in target service "content_browser". You probably need to update one or more service manifests to ensure that "content_browser" exposes "password_manager::mojom::CredentialManager" through a capability and that "content_renderer" requires that capability from the "content_browser" service. """ Maybe your recent CL fixed this already, engedy@?
,
Dec 22 2017
Thanks for looking into this, Mike. My CL actually broke this, but nothing serious -- just surprised these DCHECKs crash on continuous build, but not on try jobs :/.
,
Dec 22 2017
^ The inconsistency between the try bots and the continuous builders is a known and annoying issue, unfortunately.
,
Jan 15 2018
Looks like this has been fixed? Not seeing any crash recently: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcredential-management%2Fpasswordcredential-framed-get.sub.https.html
,
Jan 15 2018
Hmm, I haven't fixed this, and the service_manager code is untouched too. Not sure what changed. :)
,
Feb 2 2018
Still now crashes, I'll take a look an remove the CRASH expectations.
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee3be15112d8275c5f8bc4ca40ecfb891dea2865 commit ee3be15112d8275c5f8bc4ca40ecfb891dea2865 Author: Peter Mayo <petermayo@chromium.org> Date: Tue Jul 10 15:13:34 2018 wpt/credential-management re-enable Re-enable previously crashing wpt/credential-management tests This has stopped crashing for a while now. R: engedy@chromium.org Bug: crbug.com/797138 Change-Id: I86080925052aaef7a2f780710cf0e02ac5793019 Reviewed-on: https://chromium-review.googlesource.com/1131220 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573730} [modify] https://crrev.com/ee3be15112d8275c5f8bc4ca40ecfb891dea2865/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 10
Presumably the work involved with relanding engedy's CL will keep the tests non-crashy. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Dec 22 2017