New issue
Advanced search Search tips

Issue 797112 link

Starred by 3 users
Status: Assigned
Owner:
pmonette@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Fix UI issues with the blocked redirection icon and dialog (Desktop)

Project Member Reported by pmonette@chromium.org, Dec 21 2017 
Multiple issues were found with a user study for the desktop-version of the 3rd party redirect blocked UI.

P1 - expanded view strings need to be updated
P1 - omnibox icon is too small
P2 - pre-Harmony popover too wide
P3 - pre-Harmony link color incorrect, MacOS only
P3 - omnibox toast-expanded is missing vertical divider, Views only (pre-existing)
P3 - omnibox toast-expanded should collapse when popover is open (pre-existing)
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb2d85a1781ccb06bdf0b28b0372586847bd4131

commit eb2d85a1781ccb06bdf0b28b0372586847bd4131
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Jan 04 21:41:07 2018

Fix P1 issues with the blocked redirect UI for desktop platforms

- The omnibox icon size was changed
- The strings used in the dialog were changed

TBR=estade@chromium.org

Bug: 797112
Change-Id: I05d70320f41940899663d871a6dc1948ee6fd0d2
Reviewed-on: https://chromium-review.googlesource.com/841245
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527102}
[modify] https://crrev.com/eb2d85a1781ccb06bdf0b28b0372586847bd4131/chrome/app/chromium_strings.grd
[modify] https://crrev.com/eb2d85a1781ccb06bdf0b28b0372586847bd4131/chrome/app/generated_resources.grd
[modify] https://crrev.com/eb2d85a1781ccb06bdf0b28b0372586847bd4131/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/eb2d85a1781ccb06bdf0b28b0372586847bd4131/chrome/app/vector_icons/blocked_redirect.icon
[modify] https://crrev.com/eb2d85a1781ccb06bdf0b28b0372586847bd4131/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
►

Sign in to add a comment