New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797100 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 797379
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

28.9% regression in speedometer at 525532:525587

Project Member Reported by briander...@chromium.org, Dec 21 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 21 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=797100

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e42a25df0f9408c739f518a0cd94cda773c241110728e1115f876c5ff495dd24


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 22 2017

Cc: fmea...@chromium.org
Owner: fmea...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author fmeawad@chromium.org ===

Hi fmeawad@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Fadi Meawad
  Commit : 99a51fcacaad639093357727542fb1ef7c376a25
  Date   : Thu Dec 21 02:10:15 2017
  Subject: [PageLifecyle] Move the launch process state to Webkit/common

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : speedometer
  Metric       : Total/Total
  Change       : 67.54% | 15241.7005556 -> 25536.6680556

Revision             Result                  N
chromium@525531      15241.7 +- 221.375      6      good
chromium@525559      15329.0 +- 162.191      6      good
chromium@525561      15344.1 +- 160.945      6      good
chromium@525562      15324.0 +- 204.683      6      good
chromium@525563      25431.2 +- 789.514      6      bad       <--
chromium@525566      25490.9 +- 811.682      6      bad
chromium@525573      25485.2 +- 552.864      6      bad
chromium@525587      25536.7 +- 575.072      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests speedometer

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8959559480528764784


For feedback, file a bug with component Speed>Bisection
Cc: -fmea...@chromium.org altimin@chromium.org
The CL in question makes sure that if all frames in a renderer are not visible, the renderer scheduler is aware  of that.

The renderer scheduler has policies in place for throttling if none of its frames are visible.

This specific test runs chrome headless, which is by default not visible.

My suggestion is to keep the change since it is fixing an existing bug and to avoid throttling when running in headless mode.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Dec 22 2017

 Issue 797381  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Dec 23 2017

Issue 797096 has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Dec 23 2017

Issue 797399 has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Dec 24 2017

Issue 797405 has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Dec 24 2017

Issue 797431 has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Dec 27 2017

Mergedinto: 797379
Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Fadi Meawad
  Commit : e442ea0666d7af6e564fc1eb2c31deb05ed54035
  Date   : Thu Dec 21 22:54:43 2017
  Subject: Reland "[PageLifecyle] Move the launch process state to Webkit/common"

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : smoothness.image_decoding_cases
  Metric       : frame_times/yuv_decoding.html
  Change       : 3132.87% | 25.7471344394 -> 832.371975

Revision             Result                   N
chromium@525802      25.7471 +- 1.08125       6      good
chromium@525831      25.0899 +- 0.407127      6      good
chromium@525839      25.6021 +- 2.01026       6      good
chromium@525840      25.6098 +- 1.48116       6      good
chromium@525841      833.602 +- 175.911       6      bad       <--
chromium@525843      835.82 +- 177.842        6      bad
chromium@525846      802.689 +- 7.07001       6      bad
chromium@525860      832.372 +- 166.605       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=yuv.decoding.html smoothness.image_decoding_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8959033815530664352


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment