New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797093 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 797065
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

37.1% regression in system_health.memory_mobile at 524668:524705

Project Member Reported by briander...@chromium.org, Dec 21 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 21 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=797093

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=82d468d3f608a9e8d9789586fe93093b9a41f1280118c3eca1236b4f8b50162f


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 22 2017

Cc: rjwright@chromium.org
Owner: rjwright@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author rjwright@chromium.org ===

Hi rjwright@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Renee Wright
  Commit : b5d56567762b58996c1d1d1f045607e93984a382
  Date   : Mon Dec 18 14:02:16 2017
  Subject: [Ribbon] Make unneeded constructors protected & leaf classes final

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_youtube
  Change       : 35.59% | 15191381.3333 -> 20597248.0

Revision             Result                   N
chromium@524667      15191381 +- 183211       6      good
chromium@524686      17312597 +- 69003.0      6      good
chromium@524696      17287851 +- 146576       6      good
chromium@524699      18482517 +- 90688.1      6      good
chromium@524700      18408960 +- 147305       6      good
chromium@524701      20598955 +- 101602       6      bad       <--
chromium@524705      20597248 +- 158404       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8959559597227905072


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/12f36ea4840000
Cc: perezju@chromium.org sullivan@chromium.org
rjwright: can you please investigate this bug? Bisect reproduces a ~2MiB memory regression at your CL, which is quite large for Android. I kicked another bisect to double-check, but you can take a look at the memory dumps using these instructions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jan 24 2018

Cc: catapult-deps-roller@chromium.org
Owner: catapult-deps-roller@chromium.org
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12f36ea4840000

Roll src/third_party/catapult/ 6c84ef000..8a4ac91dd (1 commit)
By catapult-deps-roller@chromium.org ยท Mon Dec 18 13:51:46 2017
chromium @ 97b283f950a14bad9ff01b8a47911531589fba40

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Owner: mlamouri@chromium.org
The result from pinpoint makes a lot more sense it found, the blamed roll has a single CL:

Disable autoplay restrictions on Chrome via command line flag.
https://chromium-review.googlesource.com/831870

which is expected to have an impact on browse_media_youtube.

+mlamouri I think it's fine to WontFix or dupe to another bug where you were following on this.

Also filed go/catabug/4192 for pinpoint blaming the auto roller instead of the CL.
Mergedinto: 797065
Status: Duplicate (was: Assigned)

Sign in to add a comment