Issue metadata
Sign in to add a comment
|
37.1% regression in system_health.memory_mobile at 524668:524705 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8959559597227905072
,
Dec 22 2017
=== Auto-CCing suspected CL author rjwright@chromium.org === Hi rjwright@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Renee Wright Commit : b5d56567762b58996c1d1d1f045607e93984a382 Date : Mon Dec 18 14:02:16 2017 Subject: [Ribbon] Make unneeded constructors protected & leaf classes final Bisect Details Configuration: android_nexus5X_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_youtube Change : 35.59% | 15191381.3333 -> 20597248.0 Revision Result N chromium@524667 15191381 +- 183211 6 good chromium@524686 17312597 +- 69003.0 6 good chromium@524696 17287851 +- 146576 6 good chromium@524699 18482517 +- 90688.1 6 good chromium@524700 18408960 +- 147305 6 good chromium@524701 20598955 +- 101602 6 bad <-- chromium@524705 20597248 +- 158404 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8959559597227905072 For feedback, file a bug with component Speed>Bisection
,
Jan 23 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12f36ea4840000
,
Jan 23 2018
rjwright: can you please investigate this bug? Bisect reproduces a ~2MiB memory regression at your CL, which is quite large for Android. I kicked another bisect to double-check, but you can take a look at the memory dumps using these instructions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md
,
Jan 24 2018
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12f36ea4840000 Roll src/third_party/catapult/ 6c84ef000..8a4ac91dd (1 commit) By catapult-deps-roller@chromium.org ยท Mon Dec 18 13:51:46 2017 chromium @ 97b283f950a14bad9ff01b8a47911531589fba40 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 24 2018
The result from pinpoint makes a lot more sense it found, the blamed roll has a single CL: Disable autoplay restrictions on Chrome via command line flag. https://chromium-review.googlesource.com/831870 which is expected to have an impact on browse_media_youtube. +mlamouri I think it's fine to WontFix or dupe to another bug where you were following on this. Also filed go/catabug/4192 for pinpoint blaming the auto roller instead of the CL.
,
Jan 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 21 2017