New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797082 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 22
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.7%-20.6% regression in blink_perf.paint at 524895:524969

Project Member Reported by briander...@chromium.org, Dec 21 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 21 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=797082

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4921121f7aede5042274e0e4eb4d28fcc3b5ebc2763ea9b51b557c01e8107bd9


Bot(s) for this bug's original alert(s):

chromium-rel-mac11
chromium-rel-win7-dual
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
Kicking off a few more bisects.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jan 23 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16a281e4840000

Comment 7 by sullivan@google.com, Feb 23 2018

Re-running bisect after error fix.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Feb 24 2018

Cc: meade@chromium.org nainar@chromium.org steveanton@webrtc.org rjwright@chromium.org dullweber@chromium.org webrtc-autoroll@chromium.org deadbeef@webrtc.org pthatcher@webrtc.org oprypin@webrtc.org shend@chromium.org
Owner: shend@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 5 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12a008a0440000

Revert "Revert "[Ribbon] Remove ID arg from CSSProperty constructor"" by rjwright@chromium.org
https://chromium.googlesource.com/chromium/src/+/387ce3b31392d2fdc4fbc682f2a962ff28f4938c

Move JsepTransport from p2p/base to pc/. by deadbeef@webrtc.org
https://webrtc.googlesource.com/src/+/4770fd935ac92400487bddd3b755753572e6d692

Revert "Move JsepTransport from p2p/base to pc/." by oprypin@webrtc.org
https://webrtc.googlesource.com/src/+/8424acdde3391e1fa500da0190c63b637f8c0ce0

Roll src/third_party/webrtc/ 67c20ae57..d5247510d (8 commits) by webrtc-autoroll@chromium.org
https://chromium.googlesource.com/chromium/src/+/54a1fcbbfe557dcfcd1db91096515099aa8a6a1b

[css-typed-om] Handle list-valued strings in StylePropertyMap.set. by shend@chromium.org
https://chromium.googlesource.com/chromium/src/+/7b005686709f1bbafc9c240b51d805ceb492b6d4

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 10 by shend@chromium.org, Feb 24 2018

Owner: sullivan@chromium.org
I don't think it's my patch because it only touched files for an not-yet-shipped feature in CSS.
Owner: rjwright@chromium.org
rjwright: Looking at the pinpoint graph, this is actually 'Revert "Revert "[Ribbon] Remove ID arg from CSSProperty constructor""' causing the regression. The original land/revert were close enough together that they ran in the same perfbot cycle, which is why there aren't alerts for the original land.
Status: WontFix (was: Assigned)

Sign in to add a comment