Issue metadata
Sign in to add a comment
|
3.9%-6.3% regression in blink_perf.image_decoder at 524742:524859 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8959561264676814352
,
Dec 22 2017
=== Auto-CCing suspected CL author mtklein@chromium.org === Hi mtklein@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Mike Klein Commit : 37155d476cd727329d985b75ecedbefe380a0f23 Date : Mon Dec 18 18:48:42 2017 Subject: Rework out-of-gamut handling in SkRasterPipeline Bisect Details Configuration: android_one_perf_bisect Benchmark : blink_perf.image_decoder Metric : decode-lossy-webp/decode-lossy-webp Change : 5.75% | 563.658625 -> 596.0455 Revision Result N chromium@524741 563.659 +- 6.03567 6 good chromium@524771 565.371 +- 7.92048 6 good chromium@524786 559.617 +- 6.64368 6 good chromium@524788 562.286 +- 6.94219 6 good chromium@524788,skia@5b92ce1b24 561.088 +- 4.24128 6 good chromium@524788,skia@37155d476c 599.352 +- 7.82216 6 bad <-- chromium@524788,skia@28f89389f0 596.471 +- 3.52859 6 bad chromium@524789 596.974 +- 5.71819 6 bad chromium@524790 599.819 +- 9.95835 6 bad chromium@524793 600.586 +- 5.37454 6 bad chromium@524800 599.527 +- 11.6648 6 bad chromium@524859 596.046 +- 3.87583 6 bad Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.image_decoder More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8959561264676814352 For feedback, file a bug with component Speed>Bisection
,
Dec 22 2017
This CL did change how color management is done in Skia, so this isn't totally unexpected. I'll keep this open until I'm back in an office with an Android One device to see if I can grab a before/after profiles and confirm they've changed for the reasons I think they ought to have.
,
Jan 3 2018
Issue 798292 has been merged into this issue.
,
Jan 24 2018
,
Mar 19 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 21 2017