Issue metadata
Sign in to add a comment
|
5.5%-13.3% regression in rasterize_and_record_micro.top_25 at 524659:524807 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 21 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8959561281393885152
,
Dec 21 2017
=== Auto-CCing suspected CL author fs@opera.com === Hi fs@opera.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Fredrik Söderquist Commit : a8014bf1bc9b0c1c4b709702f404a84c5cc948cd Date : Mon Dec 18 16:48:54 2017 Subject: [PE] Invalidate <use> instances even when mutating from the parser Bisect Details Configuration: android_one_perf_bisect Benchmark : rasterize_and_record_micro.top_25 Metric : record_time/file___static_top_25_weather.html Change : 12.82% | 0.655333333333 -> 0.739333333333 Revision Result N chromium@524687 0.655333 +- 0.00702377 6 good chromium@524714 0.6495 +- 0.003937 6 good chromium@524721 0.651667 +- 0.0111056 6 good chromium@524725 0.648333 +- 0.00832666 6 good chromium@524726 0.738 +- 0.0034641 6 bad <-- chromium@524727 0.7385 +- 0.011726 6 bad chromium@524728 0.739667 +- 0.00783156 6 bad chromium@524741 0.739333 +- 0.00832666 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=file...static.top.25.weather.html rasterize_and_record_micro.top_25 More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8959561281393885152 For feedback, file a bug with component Speed>Bisection
,
Dec 22 2017
It looks like this page potentially suffer from the same issue that the commit fixed, so some additional work needs to be performed and that would be expected. I'll see if adding some additional gating (to early out even earlier, hopefully saving two function calls or so) to the invalidation command can bring down the numbers a bit.
,
Dec 22 2017
Gating the invalidation did not show any significant effect [https://chromium-review.googlesource.com/c/chromium/src/+/842822] (and shouldn't really affect record time as such, so that makes sense), so what we're seeing here is likely a regeneration of the use instances, which in turn means that recording needs to deal with more items.
,
Jan 25 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 21 2017