New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 797067 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.5%-13.3% regression in rasterize_and_record_micro.top_25 at 524659:524807

Project Member Reported by briander...@chromium.org, Dec 21 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 21 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=797067

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=11d35a207e9c1ea4ffb8807725657fdba4da3411a079ac273df2992bd4025cf2


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus7v2
android-one
android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 21 2017

Cc: f...@opera.com
Owner: f...@opera.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author fs@opera.com ===

Hi fs@opera.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Fredrik Söderquist
  Commit : a8014bf1bc9b0c1c4b709702f404a84c5cc948cd
  Date   : Mon Dec 18 16:48:54 2017
  Subject: [PE] Invalidate <use> instances even when mutating from the parser

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : rasterize_and_record_micro.top_25
  Metric       : record_time/file___static_top_25_weather.html
  Change       : 12.82% | 0.655333333333 -> 0.739333333333

Revision             Result                      N
chromium@524687      0.655333 +- 0.00702377      6      good
chromium@524714      0.6495 +- 0.003937          6      good
chromium@524721      0.651667 +- 0.0111056       6      good
chromium@524725      0.648333 +- 0.00832666      6      good
chromium@524726      0.738 +- 0.0034641          6      bad       <--
chromium@524727      0.7385 +- 0.011726          6      bad
chromium@524728      0.739667 +- 0.00783156      6      bad
chromium@524741      0.739333 +- 0.00832666      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=file...static.top.25.weather.html rasterize_and_record_micro.top_25

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8959561281393885152


For feedback, file a bug with component Speed>Bisection

Comment 4 by f...@opera.com, Dec 22 2017

Status: Started (was: Assigned)
It looks like this page potentially suffer from the same issue that the commit fixed, so some additional work needs to be performed and that would be expected.
I'll see if adding some additional gating (to early out even earlier, hopefully saving two function calls or so) to the invalidation command can bring down the numbers a bit.

Comment 5 by f...@opera.com, Dec 22 2017

Status: WontFix (was: Started)
Gating the invalidation did not show any significant effect [https://chromium-review.googlesource.com/c/chromium/src/+/842822] (and shouldn't really affect record time as such, so that makes sense), so what we're seeing here is likely a regeneration of the use instances, which in turn means that recording needs to deal with more items.

Comment 6 by f...@opera.com, Jan 25 2018

Cc: schenney@chromium.org
 Issue 797414  has been merged into this issue.

Sign in to add a comment