New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 797061 link

Starred by 2 users
Status: WontFix
Owner:
█ briander...@chromium.org
ooo
Closed: Feb 2018
Cc:
carlosil@chromium.org
█ meade@chromium.org
dmazz...@chromium.org
█ briander...@chromium.org
█ warx@chromium.org
█ yzshen@chromium.org
█ imch...@chromium.org
█ nainar@chromium.org
dullweber@chromium.org
tsepez@chromium.org
jamescook@chromium.org
skia-deps-roller@chromium.org
█ holte@chromium.org
█ rjwright@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13%-42.1% regression in blink_perf.css at 524858:525003

Project Member Reported by briander...@chromium.org, Dec 21 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 21 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=797061

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1493e31ee476c9a606c69095f0ffd81bfc1c9c83b55aa47a352145dd269ebaf7


Bot(s) for this bug's original alert(s):

android-nexus5X
android-nexus6
android-nexus7v2
android-one
android-webview-nexus5X
android-webview-nexus6
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-air
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
win-high-dpi
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 22 2017 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12bd1f7e040000

Comment 4 by sullivan@chromium.org, Jan 23 2018 

Kicking off a few more bisects.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Jan 23 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12adc0d4840000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jan 23 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14e6ea2c840000
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Jan 23 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/14908c6c840000

Comment 11 by dtu@chromium.org, Jan 25 2018 

Sorry, I pushed a bad build of Pinpoint on Tuesday. Re-running the errored jobs.
Project Member

Comment 14 by 42576172...@developer.gserviceaccount.com, Jan 25 2018

Cc: meade@chromium.org dullweber@chromium.org rjwright@chromium.org
Owner: rjwright@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14e24052840000

Revert "Revert "[Ribbon] Remove ID arg from CSSProperty constructor""
By rjwright@chromium.org · Tue Dec 19 04:00:51 2017
chromium @ 387ce3b31392d2fdc4fbc682f2a962ff28f4938c

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 15 by dullweber@chromium.org, Jan 26 2018

Cc: -dullweber@chromium.org

Comment 16 by nainar@chromium.org, Feb 2 2018

Status: WontFix (was: Assigned)
This CL was a revert.
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, Feb 2 2018

Cc: carlosil@chromium.org nainar@chromium.org imch...@chromium.org holte@chromium.org dullweber@chromium.org jamescook@chromium.org kochi@chromium.org skia-deps-roller@chromium.org dmazz...@chromium.org yzshen@chromium.org tsepez@chromium.org warx@chromium.org
Owner: kochi@chromium.org
Status: Assigned (was: WontFix)
📍 Found significant differences after each of 7 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/13aeb09c840000

[Ribbon][Reupload] Remove CSSProperty groups by rjwright@chromium.org
chromium @ 505ec4645e87ce2bfc7875b053d3f48967aabbc5

Mojo JS bindings: update some TODOs. by yzshen@chromium.org
chromium @ 5862ffc3f7ca6bf9c1287b80ac978163370da554

VariationsService now validates all signatures for HTTP requests. by carlosil@chromium.org
chromium @ f8472f5f0e0f5b399b7f5147b0e8447a85baac0b

mash: Convert HandleAccessibilityGesture method through mojo by warx@chromium.org
chromium @ 9e12fa765e2b878bb57c1d6a73655e0f162e7027

Roll src/third_party/skia/ 0b90fa88a..84bfc9589 (1 commit) by skia-deps-roller@chromium.org
chromium @ dc926f03b83cf0a4cfc242487b1a2542dd92e0f9

Revert "Revert "[Ribbon] Remove ID arg from CSSProperty constructor"" by rjwright@chromium.org
chromium @ 387ce3b31392d2fdc4fbc682f2a962ff28f4938c

Remove passing failure expectations for incremental-shadow-dom by kochi@chromium.org
chromium @ dacffa53f8006988a14be38293ad77755803dac6

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 18 by kochi@chromium.org, Feb 5 2018

Cc: -kochi@chromium.org
Owner: bradnelson@chromium.org
Mine's just a test expectation change, should not affect any perf benchmarks.

I guess this pinpoint system has a problem - assigning too many Cc will lose
focus from anyone included, and they just ignore.  And it's too hard to
revert all, or confirm the regression is *fixed*.

And reusing the same issue for different set of CLs (the OP and comment#17)
makes me wonder what is going on behind the system.

Assigning back to the original reporter.

Comment 19 by briander...@chromium.org, Feb 6 2018

Owner: briander...@chromium.org
Status: WontFix (was: Assigned)
This is WontFix. The revert brought perf back to where it was before.

Comment 20 by kochi@chromium.org, Feb 7 2018 

Oops, sorry bradnelson@ and brianderson@ for my confusion :-(
►

Sign in to add a comment