New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796998 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 21 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rogerm@chromium.org

webkit_layout_tests failing on chromium.webkit/WebKit Mac10.11 (dbg)

Builders failed on: 
- WebKit Mac10.11 (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29


 

Comment 1 by rogerm@chromium.org, Dec 21 2017

Cc: osh...@chromium.org jam@chromium.org
Components: Internals>Services
Owner: roc...@chromium.org

Unexpected Failures:
* external/wpt/credential-management/federatedcredential-framed-get.sub.https.html
* external/wpt/credential-management/passwordcredential-framed-get.sub.https.html

Culprit CL:

https://chromium-review.googlesource.com/c/chromium/src/+/815995

Comment 2 by wychen@chromium.org, Dec 21 2017

Labels: -Pri-2 Pri-1
Can the culprit CL be reverted, or disable the failed tests? This is blocking CQ.

Comment 3 by wychen@chromium.org, Dec 21 2017

Labels: -Pri-1 Pri-2
Ah. Never mind. This doesn't really block CQ.

Comment 4 by rogerm@chromium.org, Dec 21 2017

After chatting with rockot@ (CL author) and jam@ (CL reviewer), I elected not to revert because the CL is WAI in terms of finding this particular type of error and it's not blocking the CQ.

Comment 5 by roc...@chromium.org, Dec 21 2017

Fix at https://chromium-review.googlesource.com/c/chromium/src/+/840903 just waiting for security review.

Comment 6 by rogerm@chromium.org, Dec 21 2017

Cc: palmer@chromium.org
Labels: OS-Linux OS-Mac OS-Windows Type-Bug-Regression
This is failing on the Linux, Mac, and Win7 builders.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f5d389a40b1283ef1872024d33faef49369316a

commit 3f5d389a40b1283ef1872024d33faef49369316a
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Dec 21 22:38:49 2017

Add missing CredentialManager interface to browser manifest

This interface is consumed by render frames.

Bug:  796998 
Change-Id: I5e4440eb49c645a5097540b3e10c3a813fb3feee
Reviewed-on: https://chromium-review.googlesource.com/840903
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525834}
[modify] https://crrev.com/3f5d389a40b1283ef1872024d33faef49369316a/content/public/app/mojo/content_browser_manifest.json

Comment 8 by roc...@chromium.org, Dec 21 2017

Should clear up now.

Comment 9 by roc...@chromium.org, Dec 21 2017

Status: Fixed (was: Available)

Sign in to add a comment