New issue
Advanced search Search tips

Issue 796995 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Blackboxed Scripts Start Appearing Again

Reported by machineg...@gmail.com, Dec 21 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce the problem:
1. Blackbox a script in the dev tools Call Stack area by right-clicking on it and selecting the option
2. Watch it disappear from the call stack
3. Refresh
4. Go debug the same thing
5. Some of the scripts you blackboxed are back ... even though they are still blackboxed.  You can tell that they are still blackboxed because if you right-click on them the option is for "Stop Blackboxing" not "Blackbox Script" ... but if they were truly blackboxed you wouldn't even see them to be able to right-click them.

What is the expected behavior?
Blackboxed scripts behave exactly the same immediately after you blackbox them (ie. they are not shown) as when you refresh and debug the same lines of code (when they once again should not be shown).

What went wrong?
There seems to actually be three states:

Not Blackboxed: scripts appear in call stack
"Actual" Blackboxed: exists immediately after blackboxing and some of the time after refreshes/restarts
"Half" Blackboxed: scripts are blackboxed but appear anyway

It seems the "Half" category should not exist, and should always behave the same as the ones in the "Actual" category

Did this work before? N/A 

Chrome version: 62.0.3202.94  Channel: stable
OS Version: 18.2
Flash Version: 

I marked "don't know" for "did this work before", but I *think* I've seen this problem since the early days of blackboxing being introduced.  Also if it helps all the scripts I was blackboxing were React files, and one of the "Half" scripts that was visible but blackboxed was ReactCompositeComponent.js
 
Oher "Half" scripts were ReactReconciler.js, ReactMount.js, Transaction.js, ReactUpdates.js and ReactDefaultBatchingStrategy.js.  Unfortunately I can't provide the names of scripts that stayed (fully) blackboxed since they don't appear in my call stack, but they include the bulk of the other React files (since I don't see them).

Also I am using Webpack's dev server to serve these files (and I haven't tested on a normal server yet), so it's possible the bug should be renamed "Blackboxed Scripts Served by the WebPack Developer Server Start Appearing Again".  Even if that's the case though Webpack's popularity is such that I'd hope this bug would still be worth fixing.

Comment 2 Deleted

P.S. If this behavior is somehow intended for some reason then I'd like to revise this ticket to instead request that Chrome "provide a button, setting, or other mechanism to hide blackboxed scripts in the call stack."
Here's a quick screenshot of a black-boxed (but appearing) file.
blackboxing.png
16.9 KB View Download

Comment 5 by alph@chromium.org, Dec 22 2017

Owner: kozy@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 6 by kozy@chromium.org, Jan 11 2018

Could you confirm that it is still an issue in M63 or Canary? I believe we improve our CallStack Sidebar recently.
Evidently Chrome Canary isn't available on Linux (???), but I'll let you know after the next release.
HI All, I can confirm that this it is happening in windows Version 63.0.3239.132 (Official Build) (32-bit)
Status: Fixed (was: Assigned)
We reworked blackboxing management and call stack sidebar pane, so this bug should be fixed. There is minor source map issue left that we are going to address soon and it has own issue:  crbug.com/873789 

Sign in to add a comment