New issue
Advanced search Search tips

Issue 796981 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 796973



Sign in to add a comment

chrome/browser/resource_coordinator/ shouldn't depend on content/test

Project Member Reported by jam@chromium.org, Dec 21 2017

Issue description

Comment 1 by zh...@chromium.org, Dec 21 2017

Why not? It is only using content/test/test_web_contents.h and it is allowed in https://cs.chromium.org/chromium/src/chrome/browser/resource_coordinator/DEPS.

Comment 2 by jam@chromium.org, Dec 21 2017

That DEPS change was a mistake. chrome/ can only depend on content/public/test.

Comment 3 by zh...@chromium.org, Dec 21 2017

Labels: OS-Chrome OS-Linux OS-Mac
Owner: fdoray@chromium.org
Summary: chrome/browser/resource_coordinator/ shouldn't depend on content/test (was: chrome/browser/resource_coordinator/background_tab_navigation_throttle_unittest.cc shouldn't depend on content/test)
Francois, I see that there are several places using content/test/test_web_contents.h in  chrome/browser/resource_coordinator/. Do you mind fixing these all together during your refactor?

Comment 4 by fdoray@chromium.org, Jan 11 2018

Cc: fdoray@chromium.org sky@chromium.org
 Issue 796977  has been merged into this issue.

Comment 5 by fdoray@chromium.org, Jan 11 2018

Cc: chrisha@chromium.org
 Issue 796978  has been merged into this issue.

Comment 6 by fdoray@chromium.org, Jan 11 2018

 Issue 796980  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a9db19241bf0822e8a384baabbb4395260cdf97

commit 9a9db19241bf0822e8a384baabbb4395260cdf97
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Jan 12 14:39:02 2018

Remove content/test dependencies in chrome/browser/resource_coordinator/.

There is still a dependency in
chrome/browser/resource_coordinator/background_tab_navigation_throttle_unittest.cc,
but that will be handled in a separate CL as it requires more work.

Bug:  796981 
Change-Id: I88fd2f86ea74af7a9efb6c384f3d05a81f651bfb
Reviewed-on: https://chromium-review.googlesource.com/862523
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528940}
[modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
[modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/chrome/browser/resource_coordinator/tab_manager_unittest.cc
[modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/content/public/test/web_contents_tester.h
[modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/content/test/test_web_contents.cc
[modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/content/test/test_web_contents.h

Comment 8 by jam@chromium.org, Feb 15 2018

Hi, any update on the background_tab_navigation_throttle_unittest.cc include? It's the last one, thanks.

Comment 9 by fdoray@chromium.org, Feb 16 2018

Status: Started (was: Assigned)
CL sent for review: https://chromium-review.googlesource.com/c/chromium/src/+/923567

Comment 11 by jam@chromium.org, Mar 7 2018

Status: Fixed (was: Started)
Thanks!

Sign in to add a comment