chrome/browser/resource_coordinator/ shouldn't depend on content/test |
||||
Issue descriptionThis was added in https://codereview.chromium.org/2931023002
,
Dec 21 2017
That DEPS change was a mistake. chrome/ can only depend on content/public/test.
,
Dec 21 2017
Francois, I see that there are several places using content/test/test_web_contents.h in chrome/browser/resource_coordinator/. Do you mind fixing these all together during your refactor?
,
Jan 11 2018
,
Jan 11 2018
,
Jan 11 2018
Issue 796980 has been merged into this issue.
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a9db19241bf0822e8a384baabbb4395260cdf97 commit 9a9db19241bf0822e8a384baabbb4395260cdf97 Author: Francois Doray <fdoray@chromium.org> Date: Fri Jan 12 14:39:02 2018 Remove content/test dependencies in chrome/browser/resource_coordinator/. There is still a dependency in chrome/browser/resource_coordinator/background_tab_navigation_throttle_unittest.cc, but that will be handled in a separate CL as it requires more work. Bug: 796981 Change-Id: I88fd2f86ea74af7a9efb6c384f3d05a81f651bfb Reviewed-on: https://chromium-review.googlesource.com/862523 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#528940} [modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc [modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc [modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/chrome/browser/resource_coordinator/tab_manager_unittest.cc [modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/content/public/test/web_contents_tester.h [modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/content/test/test_web_contents.cc [modify] https://crrev.com/9a9db19241bf0822e8a384baabbb4395260cdf97/content/test/test_web_contents.h
,
Feb 15 2018
Hi, any update on the background_tab_navigation_throttle_unittest.cc include? It's the last one, thanks.
,
Feb 16 2018
CL sent for review: https://chromium-review.googlesource.com/c/chromium/src/+/923567
,
Feb 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/232d27cb6e5e07e61d026d40c003c1c1b9983fa2 commit 232d27cb6e5e07e61d026d40c003c1c1b9983fa2 Author: Francois Doray <fdoray@chromium.org> Date: Sat Feb 17 02:47:38 2018 Remove dependency on test_web_contents.h from background_tab_navigation_throttle_unittest.cc. Bug: 796981 Change-Id: I27809072f7d22cccec8977de71ec2312b16def4d Reviewed-on: https://chromium-review.googlesource.com/923567 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#537515} [modify] https://crrev.com/232d27cb6e5e07e61d026d40c003c1c1b9983fa2/chrome/browser/resource_coordinator/DEPS [modify] https://crrev.com/232d27cb6e5e07e61d026d40c003c1c1b9983fa2/chrome/browser/resource_coordinator/background_tab_navigation_throttle_unittest.cc [modify] https://crrev.com/232d27cb6e5e07e61d026d40c003c1c1b9983fa2/content/public/test/web_contents_tester.h [modify] https://crrev.com/232d27cb6e5e07e61d026d40c003c1c1b9983fa2/content/test/test_web_contents.cc [modify] https://crrev.com/232d27cb6e5e07e61d026d40c003c1c1b9983fa2/content/test/test_web_contents.h
,
Mar 7 2018
Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by zh...@chromium.org
, Dec 21 2017