New issue
Advanced search Search tips

Issue 796976 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocking:
issue 796973



Sign in to add a comment

components/cdm/browser/media_drm_storage_impl_unittest.cc shouldn't depend on content/test

Project Member Reported by jam@chromium.org, Dec 21 2017

Issue description

Comment 1 by xhw...@chromium.org, Dec 21 2017

jam: Any suggestions on how to simulate navigation in components/ then? I need to put MediaDrmStorageImpl (and the test) in components/ because it's also used by ChromeCast [1]

[1] https://cs.chromium.org/chromium/src/chromecast/browser/cast_content_browser_client.cc?rcl=dea436ad50902845d570c50c3d79644ccd5ed846&l=132

Comment 2 by xhw...@chromium.org, Dec 21 2017

Components: Internals>Media>Encrypted
Labels: -OS-Windows OS-Android

Comment 3 by jam@chromium.org, Dec 21 2017

I don't actually see you using internal content classes in that test. you can just switch to the public header of content/public/test/test_renderer_host.h
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc5798357ac3822eb7f23c63c1356e043439f5c2

commit dc5798357ac3822eb7f23c63c1356e043439f5c2
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Dec 21 22:38:37 2017

media: Fix MediaDrmStorageImplTest dependency

It should depend on content/public/test, not content/test.

Note in the BUILD.gn file, the test target still depend on
"//content/test:test_support" because all the content/public/test/*
files are included in that target.

BUG= 796976 

Change-Id: I1fd885301c40bc48ec65e4d19ace8aa0e8388032
Reviewed-on: https://chromium-review.googlesource.com/840615
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525833}
[modify] https://crrev.com/dc5798357ac3822eb7f23c63c1356e043439f5c2/components/cdm/browser/DEPS
[modify] https://crrev.com/dc5798357ac3822eb7f23c63c1356e043439f5c2/components/cdm/browser/media_drm_storage_impl_unittest.cc

Comment 5 by xhw...@chromium.org, Dec 21 2017

Status: Fixed (was: Assigned)

Sign in to add a comment