The user should be able to disable desktop capture throttling |
||
Issue descriptionSimilar to existing command line switches, the user should have a way to disable internal throttling for desktop capture. Currently the desktop capture is might be throttled due to content/browser/media/capture/desktop_capture_device.cc::kMaximumCpuConsumptionPercentage I suggest to add --disable-webrtc-desktop-capture-throttling.
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7debadbaf3d386be29dfd22ee475de3f71ef89a6 commit 7debadbaf3d386be29dfd22ee475de3f71ef89a6 Author: Julien Isorce <julien.isorce@chromium.org> Date: Mon Jan 15 11:53:30 2018 Add content switch --webrtc-max-cpu-consumption-percentage Useful to configure the internal kDefaultMaximumCpuConsumptionPercentage which is 50%. Espcially the user can pass the value 100 to disable throttling of the desktop capture pipeline. Typically screen capturers take <10 ms but on some hardwares it can be nearly 30 ms. It is fine to disable the throttling when the load is on the gpu. In other words even if the capture period is longer than usual, the cpu is actually very low. Bug: 796959 Tests: content_unittests --gtest_filter=*DesktopCaptureDeviceThrottledTest* Change-Id: I256278a60d369955f52c68fb7a59e65b9720da30 Reviewed-on: https://chromium-review.googlesource.com/840241 Commit-Queue: Julien Isorce <julien.isorce@chromium.org> Reviewed-by: Zijie He <zijiehe@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#529250} [modify] https://crrev.com/7debadbaf3d386be29dfd22ee475de3f71ef89a6/content/browser/media/capture/desktop_capture_device.cc [modify] https://crrev.com/7debadbaf3d386be29dfd22ee475de3f71ef89a6/content/browser/media/capture/desktop_capture_device.h [modify] https://crrev.com/7debadbaf3d386be29dfd22ee475de3f71ef89a6/content/browser/media/capture/desktop_capture_device_unittest.cc [modify] https://crrev.com/7debadbaf3d386be29dfd22ee475de3f71ef89a6/content/public/common/content_switches.cc [modify] https://crrev.com/7debadbaf3d386be29dfd22ee475de3f71ef89a6/content/public/common/content_switches.h
,
Jan 16 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by julien.isorce@chromium.org
, Dec 21 2017