New issue
Advanced search Search tips

Issue 796944 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 21 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rogerm@chromium.org

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty Leak

Builders failed on: 
- WebKit Linux Trusty Leak: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak


 

Comment 1 by rogerm@chromium.org, Dec 21 2017

Cc: jochen@chromium.org dtapu...@chromium.org
Components: Blink>Layout
Labels: Type-Bug-Regression
Owner: yhirano@chromium.org
https://chromium-review.googlesource.com/c/chromium/src/+/839787
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b7500af3b50dfd57a2ab0334cc72c709a4733f3

commit 8b7500af3b50dfd57a2ab0334cc72c709a4733f3
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Dec 21 18:55:53 2017

[Sheriff] webkit_layout_tests failing on Linux Trusty Leak

Unexpected Failures:
* external/wpt/fetch/api/request/request-keepalive-quota.html
*
virtual/mojo-blobs/external/wpt/fetch/api/request/request-keepalive-quota.html
*
virtual/outofblink-cors/external/wpt/fetch/api/request/request-keepalive-quota.html

BUG= 796944 
TBR=yhirano@chromium.org,dtapuska@chromium.org,jochen@chromium.org

Change-Id: I3e82caddb577d3c46c1ceda4a81d624066583588
Reviewed-on: https://chromium-review.googlesource.com/839787
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525755}
[modify] https://crrev.com/8b7500af3b50dfd57a2ab0334cc72c709a4733f3/third_party/WebKit/LayoutTests/LeakExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72a9933cd8917059005480622717aed1509df104

commit 72a9933cd8917059005480622717aed1509df104
Author: Roger McFarlane <rogerm@chromium.org>
Date: Thu Dec 21 23:38:15 2017

[Sheriff] Flaky tests on linux leak bot.

This CL fixes a previous leaky annotation (was mistakely marked Failure)
for external/wpt/fetch/api/request/request-keepalive-quota.html and adds
an annotation for synthetic_gestures/synthetic-pinch-zoom-gesture.html

BUG= 796944 
TBR=yhirano@chromium.org,jochen@chromium.org,dtapuska@chromium.org

Change-Id: I62ad5efa5d05ef6beec810d54c1c3335064c1099
Reviewed-on: https://chromium-review.googlesource.com/841282
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525855}
[modify] https://crrev.com/72a9933cd8917059005480622717aed1509df104/third_party/WebKit/LayoutTests/LeakExpectations

Cc: hajimehoshi@chromium.org
Status: Assigned (was: Available)
This is a kind of working-as-expected behavior because such requests should be kept alive beyond the frame destruction per spec. The resources will be released when the loading finishes, or times out.

I will modify the test to clean up the expectation file, but it doesn't change the behavior.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79c28bd2bb3fec951c8959699cf690bd8c8ec8ae

commit 79c28bd2bb3fec951c8959699cf690bd8c8ec8ae
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Sun Dec 24 23:51:19 2017

Suppress leak for request-keepalive-quota.html

The leak detector warns leaks caused by keepalive requests. The "leak" is
expected in this case per spec, so we don't fix it, but this CL modifies
the test to suppress the warning.

Bug:  796944 
Change-Id: I170c639faae5ce3fedd7f64811a5d44f3a577481
Reviewed-on: https://chromium-review.googlesource.com/842502
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526163}
[modify] https://crrev.com/79c28bd2bb3fec951c8959699cf690bd8c8ec8ae/third_party/WebKit/LayoutTests/LeakExpectations
[modify] https://crrev.com/79c28bd2bb3fec951c8959699cf690bd8c8ec8ae/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-keepalive-quota.html
[modify] https://crrev.com/79c28bd2bb3fec951c8959699cf690bd8c8ec8ae/third_party/WebKit/LayoutTests/platform/win7/external/wpt/fetch/api/request/request-keepalive-quota-expected.txt

Status: WontFix (was: Assigned)

Sign in to add a comment