Issue metadata
Sign in to add a comment
|
[Sheriff] QuicAllowedPolicyIsFalse.QuicDisallowed is flaky |
||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of rogerm@chromium.org QuicAllowedPolicyIsFalse.QuicDisallowed Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
,
Dec 21 2017
,
Dec 21 2017
,
Dec 21 2017
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9579bbf1a0853b26130a4c5408567bc21b62c37 commit c9579bbf1a0853b26130a4c5408567bc21b62c37 Author: Roger McFarlane <rogerm@chromium.org> Date: Thu Dec 21 17:20:51 2017 [Sheriff] QuicAllowedPolicyIsFalse.QuicDisallowed is flaky. Potential culprits: https://chromium-review.googlesource.com/c/chromium/src/+/837603 https://chromium-review.googlesource.com/c/chromium/src/+/833749 BUG= 796936 TBR=mmenke@chromium.org,jam@chromium.org,markusheintz@chromium.org Change-Id: I6ccb0f7876e73ae96f78de9bb1ca251bf06eb188 Reviewed-on: https://chromium-review.googlesource.com/839886 Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Markus Heintz <markusheintz@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#525724} [modify] https://crrev.com/c9579bbf1a0853b26130a4c5408567bc21b62c37/chrome/browser/policy/policy_network_browsertest.cc
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6735360825c34fa3bfb541aa35d01368049b13c commit d6735360825c34fa3bfb541aa35d01368049b13c Author: John Abd-El-Malek <jam@chromium.org> Date: Thu Dec 21 18:22:43 2017 Fix QuicAllowedPolicyIsFalse.QuicDisallowed flakiness introduced in r525444. The problem was that SystemNetworkContextManager::DisableQuic() was calling NetworkService through the mojo interface when it was running in-process. However that would race with PostTask to the IO thread to check the actual URLRequestContext's data. Fix this by using a PostTask when network service is disabled. Bug: 796936 Change-Id: I30b6b9ba1e1fb7825198df899154f59e83c671f6 Reviewed-on: https://chromium-review.googlesource.com/840260 Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#525743} [modify] https://crrev.com/d6735360825c34fa3bfb541aa35d01368049b13c/chrome/browser/net/system_network_context_manager.cc [modify] https://crrev.com/d6735360825c34fa3bfb541aa35d01368049b13c/chrome/browser/policy/policy_network_browsertest.cc
,
Jan 3 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Dec 21 2017