New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796933 link

Starred by 2 users
Status: Fixed
Owner:
█ vollick@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
█ vollick@chromium.org
█ bshe@chromium.org
tiborg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
Proj-XR
Proj-XR-VR

Blocking:
issue 715118



Sign in to add a comment

Generalize the VR asset loaded structure away from a bitmap

Project Member Reported by cjgrant@chromium.org, Dec 21 2017 
Currently, when assets are loaded on VR startup, the result is a single bitmap structure.  We should change this to be an asset structure/class, that optionally contains one or more bitmaps.  This way, when we add more assets, only the loading and UI code needs to change.

While doing this, however, we should assess how we'll load assets:

Will we always load all assets on startup?  For example, do we preload the incognito background even though it may never be used?  It will consume resources.  The current assumption is yes.

Comment 1 by cjgrant@chromium.org, Dec 21 2017

Blocking: 715118

Comment 2 by tiborg@chromium.org, Jan 2 2018

Cc: bshe@chromium.org
CC'ing bshe@ since he may want to use audio assets.

Comment 3 by cjgrant@chromium.org, Jan 4 2018

Owner: ----
Status: Available (was: Assigned)
Tibor, sanity check:  Is this something you think we should do?  I assume the passing of a raw bitmap around was a placeholder in the original code.

Comment 4 by tiborg@chromium.org, Jan 4 2018 

I think this totally depends on how we use the assets. If we always want to load all assets at once we could just add more parameters to the OnAssetsLoaded callback. Making a struct for this sounds also good to me.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d35e9c23183442a7939f8f3c685e55027b62cf

commit 92d35e9c23183442a7939f8f3c685e55027b62cf
Author: Ian Vollick <vollick@chromium.org>
Date: Sat Jan 06 03:59:28 2018

[vr] Background Tweaks

This change adds a gradient that overlays the background, stars, and
puts the grid on the ground.

Bug:  796933 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0161f973a76760befc86fc3d2aa9bac5a43ae1b1
Reviewed-on: https://chromium-review.googlesource.com/848357
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527499}
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/BUILD.gn
[delete] https://crrev.com/606fcb422c56e6678dc1ad44818d34911414fbd0/chrome/browser/vr/assets.cc
[add] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/assets_loader.cc
[rename] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/assets_loader.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/databinding/binding.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/databinding/binding_unittest.cc
[delete] https://crrev.com/606fcb422c56e6678dc1ad44818d34911414fbd0/chrome/browser/vr/elements/background.cc
[delete] https://crrev.com/606fcb422c56e6678dc1ad44818d34911414fbd0/chrome/browser/vr/elements/background.h
[add] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/environment/background.cc
[add] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/environment/background.h
[rename] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/environment/grid.cc
[rename] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/environment/grid.h
[add] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/environment/stars.cc
[add] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/environment/stars.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/elements/ui_element_name.h
[add] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/model/assets.cc
[add] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/model/assets.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/target_property.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/target_property.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui_scene_unittest.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/vr_gl_util.cc
[modify] https://crrev.com/92d35e9c23183442a7939f8f3c685e55027b62cf/chrome/browser/vr/vr_gl_util.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4804c00ec08705829db10dd35329f2938401cea3

commit 4804c00ec08705829db10dd35329f2938401cea3
Author: Ian Vollick <vollick@chromium.org>
Date: Sat Jan 06 05:01:28 2018

Revert "[vr] Background Tweaks"

This reverts commit 92d35e9c23183442a7939f8f3c685e55027b62cf.

Reason for revert: updating

Original change's description:
> [vr] Background Tweaks
> 
> This change adds a gradient that overlays the background, stars, and
> puts the grid on the ground.
> 
> Bug:  796933 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I0161f973a76760befc86fc3d2aa9bac5a43ae1b1
> Reviewed-on: https://chromium-review.googlesource.com/848357
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527499}

TBR=vollick@chromium.org,waffles@chromium.org,cjgrant@chromium.org,tiborg@chromium.org

Change-Id: Idf6261b640942dd7c69f7acd4d0c4887cc1562d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  796933 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/853412
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527508}
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/assets.cc
[rename] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/assets.h
[delete] https://crrev.com/dfacb5ac516a8ac06596c17e02963d3e5c6693bb/chrome/browser/vr/assets_loader.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/databinding/binding.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/databinding/binding_unittest.cc
[add] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/elements/background.cc
[add] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/elements/background.h
[delete] https://crrev.com/dfacb5ac516a8ac06596c17e02963d3e5c6693bb/chrome/browser/vr/elements/environment/background.cc
[delete] https://crrev.com/dfacb5ac516a8ac06596c17e02963d3e5c6693bb/chrome/browser/vr/elements/environment/background.h
[delete] https://crrev.com/dfacb5ac516a8ac06596c17e02963d3e5c6693bb/chrome/browser/vr/elements/environment/stars.cc
[delete] https://crrev.com/dfacb5ac516a8ac06596c17e02963d3e5c6693bb/chrome/browser/vr/elements/environment/stars.h
[rename] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/elements/grid.cc
[rename] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/elements/grid.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/elements/ui_element_name.h
[delete] https://crrev.com/dfacb5ac516a8ac06596c17e02963d3e5c6693bb/chrome/browser/vr/model/assets.cc
[delete] https://crrev.com/dfacb5ac516a8ac06596c17e02963d3e5c6693bb/chrome/browser/vr/model/assets.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/target_property.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/target_property.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui_scene_unittest.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/vr_gl_util.cc
[modify] https://crrev.com/4804c00ec08705829db10dd35329f2938401cea3/chrome/browser/vr/vr_gl_util.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4

commit 8e4a824f1c3a5bd4e8052abb625568d87f51d5e4
Author: Ian Vollick <vollick@chromium.org>
Date: Sat Jan 06 08:07:24 2018

Reland "[vr] Background Tweaks"

This is a reland of 92d35e9c23183442a7939f8f3c685e55027b62cf with
minor changes to the stars (missed comment and updated number of
stars). Also, thanks to tiborg@ who put in a lot of time pair-
programming with me to help convert this to an approach using
gradient images and updating all the related machinery to support
that.

TBR=waffles@chromium.org,cjgrant@chromium.org,tiborg@chromium.org
Original change's description:
> [vr] Background Tweaks
>
> This change adds a gradient that overlays the background, stars, and
> puts the grid on the ground.
>
> Bug:  796933 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I0161f973a76760befc86fc3d2aa9bac5a43ae1b1
> Reviewed-on: https://chromium-review.googlesource.com/848357
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527499}

Bug:  796933 
Change-Id: I763467953b75e4b509a47db71c6752310ee644e2
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/853413
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527515}
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/android/vr_shell/vr_shell_gl.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/component_updater/vr_assets_component_installer.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/BUILD.gn
[delete] https://crrev.com/1d0510b4a85a0831103053befd92eb2f65c15ac9/chrome/browser/vr/assets.cc
[add] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/assets_loader.cc
[rename] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/assets_loader.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/databinding/binding.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/databinding/binding_unittest.cc
[delete] https://crrev.com/1d0510b4a85a0831103053befd92eb2f65c15ac9/chrome/browser/vr/elements/background.cc
[delete] https://crrev.com/1d0510b4a85a0831103053befd92eb2f65c15ac9/chrome/browser/vr/elements/background.h
[add] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/environment/background.cc
[add] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/environment/background.h
[rename] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/environment/grid.cc
[rename] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/environment/grid.h
[add] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/environment/stars.cc
[add] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/environment/stars.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/elements/ui_element_name.h
[add] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/model/assets.cc
[add] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/model/assets.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/target_property.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/target_property.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/test/fake_ui_element_renderer.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/test/fake_ui_element_renderer.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui_element_renderer.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui_scene_unittest.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/ui_unittest.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/vr_gl_util.cc
[modify] https://crrev.com/8e4a824f1c3a5bd4e8052abb625568d87f51d5e4/chrome/browser/vr/vr_gl_util.h

Comment 8 by tiborg@chromium.org, Jan 12 2018 

Chris, is this solved now with the Assets structure?

Comment 9 by tiborg@chromium.org, Jan 22 2018

Labels: -Type-Task -M-66 M-65 Proj-VR Type-Feature
Owner: vollick@chromium.org
Status: Assigned (was: Available)
Marking as fixed since we have a structure for assets now. Lets reconsider when to load assets once we have more assets and have a better understanding when they will be needed.

Comment 10 by tiborg@chromium.org, Jan 22 2018

Status: Fixed (was: Assigned)
And actually marking it as fixed ;)

Comment 11 by dougman@chromium.org, Feb 7 2018

Labels: Test-Complete
►

Sign in to add a comment