New issue
Advanced search Search tips

Issue 796918 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

FindChildText and FindChildTextWithIgnoreList are inconsistent

Project Member Reported by olivierrobin@chromium.org, Dec 21 2017

Issue description

These two methods do not return consistent results, or results that match their documented behavior.
Fix this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5af81882884314fa13b39de387fe9824e40c139

commit b5af81882884314fa13b39de387fe9824e40c139
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Dec 22 13:49:46 2017

Add tests for form_autofill_utils

FindChildText, FindChildTextWithIgnoreList, InferLabelFromDivTableTest
sometimes have behavior that don't match the documentation.
Add some tests to capture these scenarios so they can be fixed in a
future CL.

Bug: 796918
Change-Id: I02ecb156149c8bd82470beaeff5ae2075710e380
Reviewed-on: https://chromium-review.googlesource.com/840020
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525983}
[modify] https://crrev.com/b5af81882884314fa13b39de387fe9824e40c139/components/BUILD.gn
[modify] https://crrev.com/b5af81882884314fa13b39de387fe9824e40c139/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/b5af81882884314fa13b39de387fe9824e40c139/components/autofill/content/renderer/form_autofill_util.h
[add] https://crrev.com/b5af81882884314fa13b39de387fe9824e40c139/components/autofill/content/renderer/form_autofill_util_browsertest.cc

Comment 2 by ma...@chromium.org, May 1 2018

Status: Untriaged (was: Started)
Status: Assigned (was: Untriaged)

Sign in to add a comment