Integer-overflow in es2::Context::blitFramebuffer |
|||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4737052339077120 Fuzzer: inferno_twister_c Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: es2::Context::blitFramebuffer glBlitFramebuffer gl::GLApiBase::glBlitFramebufferFn Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=495528:495531 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4737052339077120 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Dec 21 2017
Automatically adding ccs based on suspected regression changelists: Implement GL_MAX_PROGRAM_TEXEL_OFFSET and GL_MAX_TEXTURE_LOD_BIAS by sugoi@google.com - https://swiftshader.googlesource.com/SwiftShader/+/0e22d3ac1342803e4f6e99dee0b1bc7638f0acdc glGetFragDataLocation implementation by sugoi@google.com - https://swiftshader.googlesource.com/SwiftShader/+/b3f5ed7a0986d906c4f70cbf86076d9b4ec11964 If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
,
Dec 22 2017
@capn -- Could you please look into this issue as sugoi@ seems to be OOO. Thanks!
,
Dec 22 2017
This is quite interesting. The input rectangle has a coordinate with the lowest negative integer value, -2147483648 (0x80000000), which can't be negated because there's no signed 32-bit representation of 2147483648. We're still bounds checking later, so it probably doesn't result in anything fatal, but I doubt it's blitting the correct pixels. The solution is probably to trim them to the source and destination dimensions earlier. Assigning to sugoi@ since he's been working on this code very recently.
,
Jan 13 2018
ClusterFuzz has detected this issue as fixed in range 529109:529110. Detailed report: https://clusterfuzz.com/testcase?key=4737052339077120 Fuzzer: inferno_twister_c Job Type: linux_ubsan_chrome Platform Id: linux Crash Type: Integer-overflow Crash Address: Crash State: es2::Context::blitFramebuffer glBlitFramebuffer gl::GLApiBase::glBlitFramebufferFn Sanitizer: undefined (UBSAN) Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=495528:495531 Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=529109:529110 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4737052339077120 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jan 13 2018
ClusterFuzz testcase 4737052339077120 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ClusterFuzz
, Dec 21 2017Labels: Test-Predator-Auto-Components