New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 796902 link

Starred by 1 user
Status: Fixed
Owner:
█ olka@chromium.org
OOO Dec 22 - Jan 8
Closed: Jan 2018
Cc:
huib@chromium.org
solenberg@chromium.org
peah@chromium.org
grunell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task



Sign in to add a comment

Add traces for timestamp and delay estimation in audio playback/capture pipeline

Project Member Reported by olka@chromium.org, Dec 21 2017 
Add traces to both browser and renderer sides of input/output audio pipeline to capture information relevant to delay estimations we pass to AMP in MediaStreamAudioProcessor::ProcessData().

This will help us to verify correctness of delay estimations when we are observing echo in WebRTC calls.

From the traces we'll also be able to distinguish between Chrome audio stack issues and cases where incorrect timestamps are provided by the underlying platform.

Comment 1 by olka@chromium.org, Dec 21 2017

Summary: Add traces for timestamp and delay estimation in audio playback/capture pipeline (was: Add traces for timestamp and delay estimation to audio playback/capture pipeline)

Comment 2 by dalecur...@chromium.org, Jan 8 2018 

Output side should already have traces in M65+ with the delay information.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acbf1d475adfd72964c449e7db273f92e0b7b3fe

commit acbf1d475adfd72964c449e7db273f92e0b7b3fe
Author: Olga Sharonova <olka@chromium.org>
Date: Mon Jan 15 14:57:27 2018

Traces for audio playback/capture timestamps and delays.

TBR=rtoy@chromium.org

Bug:  796902 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6011edf8186fb067414d934dad48bb12dc1de826
Reviewed-on: https://chromium-review.googlesource.com/866716
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529281}
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/content/browser/renderer_host/media/audio_input_sync_writer.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/content/renderer/media/media_stream_audio_deliverer.h
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/content/renderer/media/media_stream_audio_processor.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/content/renderer/media/track_audio_renderer.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/content/renderer/media/webrtc/processed_local_audio_source.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/content/renderer/media/webrtc_audio_device_impl.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/media/audio/audio_input_controller.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/media/audio/audio_input_device.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/media/audio/audio_output_controller.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/media/audio/audio_output_device.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/media/base/audio_shifter.cc
[modify] https://crrev.com/acbf1d475adfd72964c449e7db273f92e0b7b3fe/third_party/WebKit/Source/platform/audio/AudioDestination.cpp

Comment 4 by olka@chromium.org, Jan 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment