New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796900 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Print interstitial page and custom margins forgets changes made

Project Member Reported by vmalewar@google.com, Dec 21 2017

Issue description

Chrome Version       : 63.0.3239.84 (Official Build) (64-bit) (cohort: Stable), Revision 8f51ed0e633e109109762a3deb18a50e8c138819-refs/branch-heads/3239@{#643}
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:
     Safari:
    Firefox:
       Edge:

What steps will reproduce the problem?
(1) Press Ctrl+P to bring up Print interstitial page
(2) Make changes to settings - ex. check/uncheck 'two sided'/'header and footer' and in Advanced change 'Job Type' to 'Secure Print' and change 'Secure Print Digit' to something of your choice
(3) Print the page
(4) Open Ctrl+P page again

What is the expected result?
All changes to the page ex. 'two sided' or 'secure print' should be remembered next time Ctrl+P page is invoked

What happens instead?
'Secure Print' and other changes in Advanced page are NOT remembered. The basic changes ex. 'two sided' are saved correctly though

Please provide any additional information below. Attach a screenshot if
possible.
https://screenshot.googleplex.com/qQU1WvH55rT
 
Components: Internals>Printing
Cc: hwi@chromium.org jawag@chromium.org dpa...@chromium.org
Components: -Internals>Printing UI>Browser>PrintPreview
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows Pri-3 Type-Feature
Status: Available (was: Unconfirmed)
Print Preview does not save all settings, only the ones that have been selected to be "sticky". This is intentional, because restoring all settings might surprise the user. For example with copies it would probably be undesirable to restore a value of 100 if the user printed 100 copies on the last page they printed.

CC-ing some people who are looking at Print Preview features currently. We can look into whether it makes sense to make the "advanced settings" options sticky in future. Note that this does not apply to local printers currently as they do not use CDDs and therefore do not have an advanced settings section.

Comment 3 by vmalewar@google.com, Dec 21 2017

Thanks rbpotter@ for responding. Is this a recent change? I've been using Secure Print for past ~1.5yrs it was always saved. I noticed that print jobs were going as normal prints only last week (Not sure if it was due to a recent update or something else I did!)

To think of it - Secure print reverting back to (default) Normal print is a bigger problem than Normal print accidentally going as Secure Print because I forgot to turn it back. 
Labels: -Type-Feature Type-Bug-Regression
RE: reverting to normal vs secure, it will default to whatever the printer's default value is. I am guessing that is normal printing.

Took another look and it does look like we try to save off settings if they are detected as user modified (it is just implemented somewhat differently from how the other settings are saved so I missed it originally). This worked in 62 at least for the "Print mode" setting. Think I have a fix for this.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7528b27f624c261490721f3c553fe23b3bf507

commit 8e7528b27f624c261490721f3c553fe23b3bf507
Author: rbpotter <rbpotter@chromium.org>
Date: Fri Dec 22 03:45:14 2017

Print Preview: Fix vendor items persistence

Bug:  796900 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I293891ea58306f531303a9d89dc5d06b13b76644
Reviewed-on: https://chromium-review.googlesource.com/841147
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525921}
[modify] https://crrev.com/8e7528b27f624c261490721f3c553fe23b3bf507/chrome/browser/resources/print_preview/data/print_ticket_store.js

Comment 6 by vmalewar@google.com, Dec 22 2017

Thank you. Appreciate your quick response.
Owner: rbpotter@chromium.org
Status: Started (was: Available)
vmalewar: Can you try Google Chrome Canary in a few days and verify the fix? It's probably too late to fix this for Chrome 63. The best we can do is merge this fix to Chrome 64 at this point.

Comment 8 by vmalewar@google.com, Dec 22 2017

Will try it out. There's no rush from my end anyway.
Labels: TE-Verified-M65 TE-Verified-65.0.3309.0
Verified this issue on Ubuntu 14.04, Mac OS 10.12.6 and Windows-10 using chrome latest canary M65 #65.0.3309.0 by following steps mentioned in the original comment. Observed 'Secure Print' and other changes in Advanced page is remembered as expected. Hence adding TE-Verified label for M65.

Thanks!
796900.png
120 KB View Download
Cc: viswatej...@techmahindra.com sc00335...@techmahindra.com ranjitkan@chromium.org rbpotter@chromium.org pbomm...@chromium.org
 Issue 797509  has been merged into this issue.
Status: Fixed (was: Started)
Labels: Merge-Request-64
Requesting merge to M64 as suggested in comment 7.
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 2 2018

Labels: -Merge-Request-64 Merge-Reject-64 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M64 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 -Hotlist-Merge-Reject -Merge-Reject-64 Merge-Request-64 Pri-2
Updated priority since  bug 797509  (same issue as this one and merged in) was marked P2 and Release Block Stable.
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 2 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Summary: Print interstitial page and custom margins forgets changes made (was: Print interstitial page forgets changes made)
Labels: -Merge-Review-64 Merge-Approved-64
Approving merge for M64. Branch:3282
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 3 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee88331b20a0a902f18bea9581896485253d8698

commit ee88331b20a0a902f18bea9581896485253d8698
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jan 03 00:52:23 2018

Print Preview: Fix vendor items persistence (M64)

Bug:  796900 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I293891ea58306f531303a9d89dc5d06b13b76644
Reviewed-on: https://chromium-review.googlesource.com/841147
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525921}(cherry picked from commit 8e7528b27f624c261490721f3c553fe23b3bf507)

TBR=dpapad@chromium.org

Change-Id: I293891ea58306f531303a9d89dc5d06b13b76644
Reviewed-on: https://chromium-review.googlesource.com/848332
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#387}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/ee88331b20a0a902f18bea9581896485253d8698/chrome/browser/resources/print_preview/data/print_ticket_store.js

Labels: TE-Verified-M64 TE-Verified-64.0.3282.71
Verified this issue on Ubuntu 14.04, Mac OS 10.12.6 and Windows-10 using chrome latest beta M64 #64.0.3282.71 as well and observed 'Secure Print' and other changes in Advanced page is remembered as expected. Hence adding TE-Verified label for M64.

Thanks!
Cc: susanjun...@techmahindra.com
 Issue 804158  has been merged into this issue.
 Issue 803793  has been merged into this issue.
Cc: thestig@chromium.org kkaluri@chromium.org jayhlee@chromium.org
 Issue 806335  has been merged into this issue.
Labels: -Restrict-View-Google allpublic
A user requested to see this bug, and it has nothing confidential, so removing RVG.

Sign in to add a comment