Finalize DSE notification strings |
||
Issue descriptionIssue to track the discussion here about permission strings given the DSE notification permission change: https://docs.google.com/presentation/d/1gX4tzXuK67fpOk5bj0CsKKS00P-rZbUrkBlFyPKCDf0/edit#slide=id.g2c8e405fae_0_60
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83f2ebc000531524cbac19d7b02a895544460afe commit 83f2ebc000531524cbac19d7b02a895544460afe Author: Raymes Khoury <raymes@chromium.org> Date: Mon Jan 15 03:18:18 2018 Update strings for DSE Notifications A string that appears under the search engine in Settings>Search Engines has been updated to be clearer, as per the discussion in the doc linked in crbug.com/796892 . Also, the text in Site Settings that notifies the user that device location is turned off has also been updated per that discussion. Bug: 796892 Change-Id: I028c52ba288226d180035935d4ec01e0558820ae Reviewed-on: https://chromium-review.googlesource.com/853735 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#529193} [modify] https://crrev.com/83f2ebc000531524cbac19d7b02a895544460afe/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 5
It seems that this bug can be closed as the issue that it is blocking has been closed and there is a CR submitted. I assume the only issue that came out of the discussion was updating the 2 text strings. |
||
►
Sign in to add a comment |
||
Comment 1 by owe...@chromium.org
, Dec 21 2017