New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796873 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX



Sign in to add a comment

Show sound setting in site setting when site is using sound

Project Member Reported by mlamouri@chromium.org, Dec 21 2017

Issue description

This is feedback from meggynwatkins@, filing bug on their behalf.

On Chrome Android, when a website is making sound, the OIB will show "Sound - Allowed" but then pressing "Site Settings" will not show the "Sound" entry. It can be a bit confusing and makes blocking sound particularly hard for users.

It would be great if we show the sound site setting when the website has been using sound to make that flow smooth and predictable.

steimel@, amyroberts@, dahlke@, WDYT?
 
We're hoping this will be solved via crbug.com/764199, which will show all settings in Site Settings. Not sure on timeframe for that crbug though, so it could be worth implementing a temporary fix that'll show sound when sound is playing. WDYT?
Will bug 764199 include changing the value of the setting too?

If it's not too hard technically to fix this, I think it would be good to do it without waiting for other fixes. I think it would help users to mute a website that is misbehaving.
Cc: raymes@chromium.org
Owner: steimel@chromium.org
Status: Assigned (was: Available)
IIUC, yes it includes changing the value of the setting. I agree that it would be a huge help for site muting, so I can look into what it would take to get this to work for sound for now
Cc: emilyschechter@chromium.org
Components: UI>Browser>SiteSettings
Having sound always show up in Site Settings on Android sounds like a reasonable short term solution to me. I guess it would default to "Allow" and tapping "Clear and Reset" would reset it back to "Allow"?

emilyschechter: does this seem ok with you? 
Status: Started (was: Assigned)
This sounds fine as a short term solution, though ideally we'll fix bug 764199 :)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f603fc5739f16f7557f7d9ca6d99e0e6efeb5536

commit f603fc5739f16f7557f7d9ca6d99e0e6efeb5536
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Jan 29 14:51:58 2018

Always show sound in site settings on Android

This CL modifies the SingleWebsitePreferences setup to always show the
sound setting even when it's not currently set by showing the default
setting as selected.

Bug:  796873 
Change-Id: Id7dec2bb0e75ee138dae95bbd219c569794d2b09
Reviewed-on: https://chromium-review.googlesource.com/889519
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532425}
[modify] https://crrev.com/f603fc5739f16f7557f7d9ca6d99e0e6efeb5536/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
[modify] https://crrev.com/f603fc5739f16f7557f7d9ca6d99e0e6efeb5536/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java

Status: Fixed (was: Started)
This is now fixed. Is this something we want to patch into M65, or are we okay waiting until it gets naturally released with M66? Given how much more usable site muting becomes on Android with this change, my preference is to patch it into M65

Comment 9 by dah...@chromium.org, Jan 29 2018

65 would be my preference as well. 
Labels: Merge-Request-65
Project Member

Comment 11 by sheriffbot@chromium.org, Feb 2 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 2 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4be80ac6d260af6ed4b7e57a31639ad906508241

commit 4be80ac6d260af6ed4b7e57a31639ad906508241
Author: Tommy Steimel <steimel@chromium.org>
Date: Fri Feb 02 15:29:24 2018

Always show sound in site settings on Android

This CL modifies the SingleWebsitePreferences setup to always show the
sound setting even when it's not currently set by showing the default
setting as selected.

Bug:  796873 
Change-Id: Id7dec2bb0e75ee138dae95bbd219c569794d2b09
Reviewed-on: https://chromium-review.googlesource.com/889519
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#532425}(cherry picked from commit f603fc5739f16f7557f7d9ca6d99e0e6efeb5536)
Reviewed-on: https://chromium-review.googlesource.com/898194
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#259}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/4be80ac6d260af6ed4b7e57a31639ad906508241/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
[modify] https://crrev.com/4be80ac6d260af6ed4b7e57a31639ad906508241/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java

Sign in to add a comment