New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796865 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: SSID and Password is not aligned in Connect to Network overlay when language is changed to Arabic

Project Member Reported by kebalaji@chromium.org, Dec 21 2017

Issue description

Chrome Version: 65.0.3299.0/10234.0.0 dev channel  Daisy,Kip & Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover Build>> In OOBE screen, Change the language to Arabic
(2)Navigate to Connect to Network overlay>> Click on some WiFi connection and Observe

Expected: SSID and Password should be left aligned
Actual:Instead,  SSID and Password is center aligned

This is a Regression issue as same is working fine on 65.0.3286.0/10191.0.0 dev channel Gnawty.

NOTE: Issue is not seen on Linux and Windows

@Alemate: Please confirm the issue
 
ActualSP.mp4
5.8 MB View Download
ExpectedSP.mp4
4.4 MB View Download
Owner: steve...@chromium.org
Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Hi Team,

Thank you for reporting this issue, however this is not a localization case. I'll be looping in the Engineering Team for review.

Happy Holidays everyone!

Regards!
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b301a6526484d3419a096a874c00b38e69e63988

commit b301a6526484d3419a096a874c00b38e69e63988
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 23 01:29:33 2018

Fix RTL in network and bluetooth WebUI dialogs

The <html> tag was incorrect for RTL.



Bug:  796865 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaebe56c3019f37ee937480af0ac1c847fc291842
Reviewed-on: https://chromium-review.googlesource.com/875157
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531113}
[modify] https://crrev.com/b301a6526484d3419a096a874c00b38e69e63988/chrome/browser/resources/chromeos/bluetooth_pairing_dialog.html
[modify] https://crrev.com/b301a6526484d3419a096a874c00b38e69e63988/chrome/browser/resources/chromeos/internet_config_dialog.html
[modify] https://crrev.com/b301a6526484d3419a096a874c00b38e69e63988/chrome/browser/resources/chromeos/internet_detail_dialog.html

Labels: Merge-Request-65
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 24 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33977f27e3bc45d4f90ce352be3c9b9c2cec1b6e

commit 33977f27e3bc45d4f90ce352be3c9b9c2cec1b6e
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 24 18:23:36 2018

Fix RTL in network and bluetooth WebUI dialogs

The <html> tag was incorrect for RTL.



TBR=stevenjb@chromium.org

(cherry picked from commit b301a6526484d3419a096a874c00b38e69e63988)

Bug:  796865 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaebe56c3019f37ee937480af0ac1c847fc291842
Reviewed-on: https://chromium-review.googlesource.com/875157
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531113}
Reviewed-on: https://chromium-review.googlesource.com/883904
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#65}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/33977f27e3bc45d4f90ce352be3c9b9c2cec1b6e/chrome/browser/resources/chromeos/bluetooth_pairing_dialog.html
[modify] https://crrev.com/33977f27e3bc45d4f90ce352be3c9b9c2cec1b6e/chrome/browser/resources/chromeos/internet_config_dialog.html
[modify] https://crrev.com/33977f27e3bc45d4f90ce352be3c9b9c2cec1b6e/chrome/browser/resources/chromeos/internet_detail_dialog.html

Sign in to add a comment