New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796862 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 799592
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 796433



Sign in to add a comment

Pre-CQ BuildPackage fails on chromeos-config (on Reef

Reported by vpalatin@chromium.org, Dec 21 2017

Issue description

I'm seeing pre-CQ failures which doesn't related to the CL in the pre-CQ.

e.g 
https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/no_vmtest_pre_cq/197365
fails on BuildPackages for board reef
with :
https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromiumos.tryserver%2Fno_vmtest_pre_cq%2F197365%2F%2B%2Frecipes%2Fsteps%2FBuildPackages%2F0%2Fstdout

chromeos-config-0.0.1-r9: Traceback (most recent call last):
chromeos-config-0.0.1-r9:   File "/usr/lib/python-exec/python2.7/cros_config_schema", line 9, in <module>
chromeos-config-0.0.1-r9:     load_entry_point('cros-config-host==1', 'console_scripts', 'cros_config_schema')()
chromeos-config-0.0.1-r9:   File "/usr/lib64/python2.7/site-packages/cros_config_host/v2/cros_config_schema.py", line 292, in main
chromeos-config-0.0.1-r9:     Main(args.schema, args.config, args.output, args.filter)
chromeos-config-0.0.1-r9:   File "/usr/lib64/python2.7/site-packages/cros_config_host/v2/cros_config_schema.py", line 278, in Main
chromeos-config-0.0.1-r9:     json_transform = TransformConfig(config_stream.read())
chromeos-config-0.0.1-r9:   File "/usr/lib64/python2.7/site-packages/cros_config_host/v2/cros_config_schema.py", line 118, in TransformConfig
chromeos-config-0.0.1-r9:     audio['files'] = _GetAudioFiles(model)
chromeos-config-0.0.1-r9:   File "/usr/lib64/python2.7/site-packages/cros_config_host/v2/cros_config_schema.py", line 138, in _GetAudioFiles
chromeos-config-0.0.1-r9:     card = model.audio.main.card
chromeos-config-0.0.1-r9: AttributeError: 'Config' object has no attribute 'card'
chromeos-config-0.0.1-r9:  * ERROR: chromeos-base/chromeos-config-0.0.1-r9::chromiumos failed (compile phase):
chromeos-config-0.0.1-r9:  *   Validation failed
chromeos-config-0.0.1-r9:  * 
chromeos-config-0.0.1-r9:  * Call stack:
chromeos-config-0.0.1-r9:  *     ebuild.sh, line  93:  Called src_compile
chromeos-config-0.0.1-r9:  *   environment, line 1281:  Called die
chromeos-config-0.0.1-r9:  * The specific snippet of code:
chromeos-config-0.0.1-r9:  *           cros_config_schema -c "${yaml}" -o "${json}" -f "True" || die "Validation failed";

Might be related to the CL:
https://chromium-review.googlesource.com/#/c/chromiumos/platform2/+/837151/
 
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d931f76d568da3dbef734509ce7ce8b142a4fc85

commit d931f76d568da3dbef734509ce7ce8b142a4fc85
Author: C Shapiroc <shapiroc@chromium.org>
Date: Thu Dec 21 16:04:28 2017

chromeos-config: Fix dict to pop

Issues with pre-cq allowed this bug to get submitted.

BUG= chromium:796862 
TEST=emerge-reef chromeos-config

Change-Id: Id255526ab39dfce33a10fa4f68b6f5bfd5e1cccd
Reviewed-on: https://chromium-review.googlesource.com/839984
Reviewed-by: C Shapiro <shapiroc@google.com>
Tested-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/d931f76d568da3dbef734509ce7ce8b142a4fc85/chromeos-config/cros_config_host/v2/cros_config_schema.py

Cc: pprabhu@chromium.org shapiroc@chromium.org jen...@chromium.org martinroth@chromium.org kroot@chromium.org bmgordon@chromium.org jrbarnette@chromium.org victorhsieh@chromium.org
 Issue 796949  has been merged into this issue.
Blocking: 796433
Components: Infra

Comment 7 by mmoss@chromium.org, Jan 2 2018

Components: -Infra Infra>Client>ChromeOS
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".]
Mergedinto: 799592
Status: Duplicate (was: Untriaged)

Sign in to add a comment