Issue metadata
Sign in to add a comment
|
Regression: Unnecessarily on screen keyboard is seen in Connect to Network overlay |
||||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3299.0/10234.0.0 dev channel Daisy,Kip & Reks OS:Chrome OS What steps will reproduce the problem? (1)Recover Build>> In OOBE screen, Enable Chromevox (2)Now, Enable and disable On screen keyboard (3)Navigate to Connect to Network overlay>> Click on any Wifi connection and on Password field>> Observe Actual: Unnecessary on screen keyboard is seen Expected: No such should be seen This is a Regression issue as same is working fine on 65.0.3286.0/10191.0.0 dev channel Gnawty. NOTE: Issue is not seen on Linux and Windows
,
Dec 21 2017
Did you try other UIs? It looks like the on screen keyboard somehow did not actually get disabled?
,
Dec 22 2017
Iam able to reproduce the issue on Sign into Chromebook overlay as well. Unable to reproduce on Sign-out screen. Thanks!
,
Jan 26 2018
Whom is the right owner for this? It is marked as a beta blocker for 65, and the beta promotion date is only a week away.
,
Jan 26 2018
,
Jan 26 2018
Issue 797643 has been merged into this issue.
,
Jan 26 2018
According to the merged issue, it's an intended behavior, but we still have two problems. 1. On-screen keyboard option should be set to true forcibly when ChromeVox is enabled. 2. Shown keyboard is normal virtual keyboard, not a11y keyboard. We should show a11y keyboard in this case. I'm going to fix the keyboard type issue. It would be great if anyone can fix OOBE screen issue.
,
Jan 26 2018
Please don't enable the a11y virtual keyboard. For context, I made the change in order for spoken feedback to be able to programmatically inject editing commands from an extension background page context. This was done to avoid having to wire up an entire private api to pass through key events which would duplicate much or most of the chrome.virtualKeyboardPrivate api. ChromeVox, spoken feedback, needs this functionality to support braille hardware keyboards. Ideally, chrome.virtualKeyboardPrivate would work without vk being enabled. Alternatively, I can look into hooking up another private api to inject keys. What is not desired is for a11y keyboard to be enabled. The a11y vk gets shown even when there's no text field in focus.
,
Jan 26 2018
,
Jan 26 2018
,
Feb 1 2018
We need to promote to beta soon, is there any chance we can get the fix landed in the next day or so?
,
Feb 1 2018
The fix https://chromium-review.googlesource.com/c/chromium/src/+/889040 is awaiting one more lg. I think we can land it today, but it still needs to be merged into 65.
,
Feb 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7 commit 281f5ffbccda650bc31d3ab4b0a50be210dd5bd7 Author: David Tseng <dtseng@chromium.org> Date: Fri Feb 02 23:30:55 2018 Add accessibilityPrivate.sendSyntheticKeyEvent Bug: 796861 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I54973fff39522225398d490877c2d03690dfd71f Reviewed-on: https://chromium-review.googlesource.com/889040 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#534192} [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/accessibility/DEPS [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/accessibility/accessibility_extension_api.cc [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/accessibility/accessibility_extension_api.h [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/chromeos/accessibility/accessibility_manager.h [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/common/extensions/api/accessibility_private.json [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/third_party/closure_compiler/externs/accessibility_private.js [modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/tools/metrics/histograms/enums.xml
,
Feb 2 2018
,
Feb 3 2018
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 5 2018
I think this is ok as the DEPS change referenced is just a header file addition, not changing an underlying git hash. Assuming this is the case, approving the merge.
,
Feb 5 2018
Can we pick this change back today? We are hoping to have a beta quality build tonight to push to dev tomorrow, so we can promote it to beta later this week.
,
Feb 5 2018
I'll land tonight. I'm going to guess it won't apply cleanly due to the histogram changes, so I'll have to hand merge.
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ada3ea916b3aad70a2210335dfad89d7c924df2d commit ada3ea916b3aad70a2210335dfad89d7c924df2d Author: David Tseng <dtseng@chromium.org> Date: Tue Feb 06 00:22:33 2018 Merge to m65: Add accessibilityPrivate.sendSyntheticKeyEvent TBR=dtseng@chromium.org Bug: 796861 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I54973fff39522225398d490877c2d03690dfd71f Reviewed-on: https://chromium-review.googlesource.com/889040 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534192} Reviewed-on: https://chromium-review.googlesource.com/902801 Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#328} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/accessibility/DEPS [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/accessibility/accessibility_extension_api.cc [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/accessibility/accessibility_extension_api.h [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/chromeos/accessibility/accessibility_manager.cc [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/chromeos/accessibility/accessibility_manager.h [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/common/extensions/api/accessibility_private.json [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/third_party/closure_compiler/externs/accessibility_private.js [modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/tools/metrics/histograms/enums.xml
,
Feb 6 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by alemate@chromium.org
, Dec 21 2017