New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796861 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility



Sign in to add a comment

Regression: Unnecessarily on screen keyboard is seen in Connect to Network overlay

Project Member Reported by kebalaji@chromium.org, Dec 21 2017

Issue description

Chrome Version: 65.0.3299.0/10234.0.0 dev channel  Daisy,Kip & Reks
OS:Chrome OS

What steps will reproduce the problem?
(1)Recover Build>> In OOBE screen, Enable Chromevox 
(2)Now, Enable and disable On screen keyboard 
(3)Navigate to Connect to Network overlay>> Click on any Wifi connection and on Password field>> Observe

Actual: Unnecessary on screen keyboard is seen
Expected: No such should be seen

This is a Regression issue as same is working fine on 65.0.3286.0/10191.0.0 dev channel Gnawty.

NOTE: Issue is not seen on Linux and Windows
 
ActualOSK.mp4
5.8 MB View Download
ExpectedOSK.mp4
5.1 MB View Download
Cc: steve...@chromium.org
Did you try other UIs? It looks like the on screen keyboard somehow did not actually get disabled?

Iam able to reproduce the issue on Sign into Chromebook overlay as well.
Unable to reproduce on Sign-out screen.

Thanks!
Cc: abodenha@chromium.org
Whom is the right owner for this?

It is marked as a beta blocker for 65, and the beta promotion date is only a week away.
Owner: yhanada@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by yawano@chromium.org, Jan 26 2018

Cc: yhanada@chromium.org yawano@chromium.org dtseng@chromium.org blakeo@chromium.org
 Issue 797643  has been merged into this issue.
Components: UI>Input>VirtualKeyboard
According to the merged issue, it's an intended behavior, but we still have two problems.

1. On-screen keyboard option should be set to true forcibly when ChromeVox is enabled.
2. Shown keyboard is normal virtual keyboard, not a11y keyboard. We should show a11y keyboard in this case.

I'm going to fix the keyboard type issue.
It would be great if anyone can fix OOBE screen issue.

Comment 8 by dtseng@chromium.org, Jan 26 2018

Please don't enable the a11y virtual keyboard.
For context, I made the change in order for spoken feedback to be able to programmatically inject editing commands from an extension background page context. This was done to avoid having to wire up an entire private api to pass through key events which would duplicate much or most of the chrome.virtualKeyboardPrivate api. ChromeVox, spoken feedback, needs this functionality to support braille hardware keyboards.

Ideally, chrome.virtualKeyboardPrivate would work without vk being enabled.

Alternatively, I can look into hooking up another private api to inject keys.

What is not desired is for a11y keyboard to be enabled. The a11y vk gets shown even when there's no text field in focus.

Comment 9 by dtseng@chromium.org, Jan 26 2018

Owner: dtseng@chromium.org
Status: started (was: Assigned)
We need to promote to beta soon, is there any chance we can get the fix landed in the next day or so?

Comment 12 Deleted

The fix
https://chromium-review.googlesource.com/c/chromium/src/+/889040
is awaiting one more lg. I think we can land it today, but it still needs to be merged into 65.


Project Member

Comment 14 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7

commit 281f5ffbccda650bc31d3ab4b0a50be210dd5bd7
Author: David Tseng <dtseng@chromium.org>
Date: Fri Feb 02 23:30:55 2018

Add accessibilityPrivate.sendSyntheticKeyEvent

Bug:  796861 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I54973fff39522225398d490877c2d03690dfd71f
Reviewed-on: https://chromium-review.googlesource.com/889040
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534192}
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/accessibility/DEPS
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/accessibility/accessibility_extension_api.h
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/chrome/common/extensions/api/accessibility_private.json
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/third_party/closure_compiler/externs/accessibility_private.js
[modify] https://crrev.com/281f5ffbccda650bc31d3ab4b0a50be210dd5bd7/tools/metrics/histograms/enums.xml

Labels: Merge-Request-65
Project Member

Comment 16 by sheriffbot@chromium.org, Feb 3 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
I think this is ok as the DEPS change referenced is just a header file addition, not changing an underlying git hash.

Assuming this is the case, approving the merge.
Can we pick this change back today?

We are hoping to have a beta quality build tonight to push to dev tomorrow, so we can promote it to beta later this week. 
I'll land tonight. I'm going to guess it won't apply cleanly due to the histogram changes, so I'll have to hand merge.
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 6 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ada3ea916b3aad70a2210335dfad89d7c924df2d

commit ada3ea916b3aad70a2210335dfad89d7c924df2d
Author: David Tseng <dtseng@chromium.org>
Date: Tue Feb 06 00:22:33 2018

Merge to m65: Add accessibilityPrivate.sendSyntheticKeyEvent

TBR=dtseng@chromium.org

Bug:  796861 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I54973fff39522225398d490877c2d03690dfd71f
Reviewed-on: https://chromium-review.googlesource.com/889040
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#534192}
Reviewed-on: https://chromium-review.googlesource.com/902801
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#328}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/accessibility/DEPS
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/accessibility/accessibility_extension_api.cc
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/accessibility/accessibility_extension_api.h
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler.js
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/constants.js
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/chrome/common/extensions/api/accessibility_private.json
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/third_party/closure_compiler/externs/accessibility_private.js
[modify] https://crrev.com/ada3ea916b3aad70a2210335dfad89d7c924df2d/tools/metrics/histograms/enums.xml

Status: fixed (was: Started)

Sign in to add a comment