Issue metadata
Sign in to add a comment
|
Regression: Black flashes are seen in Fishbowl page |
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3299.0/10234.0.0 dev channel Daisy,Kip & Reks OS:Chrome OS What steps will reproduce the problem? (1)Sign into user >>Open https://testdrive-archive.azurewebsites.net/performance/fishbowl/default.html and Observe Black flash(please refer video) Actual:Screen flashes continuosly Expected:No such black flash should be seen. This is a Regression issue as same is working fine in 65.0.3286.0/10191.0.0 dev channel daisy Note:Issue is not seen in Linux,Windows OS
,
Jan 12 2018
->marcheu to find a Chrome OS gfx owner to triage / bisect.
,
Jan 17 2018
note to self: a good repro + bisect target is braswell/cyan (ARM simple chrome build is broken ATM) with 1 fishbowlie and 1 maps zooming in and out.
,
Jan 18 2018
2e4a432454ac3f04d6c5fa8f17c49ce3026217d6 is the first bad commit commit 2e4a432454ac3f04d6c5fa8f17c49ce3026217d6 Author: Justin Novosad <junov@chromium.org> Date: Thu Dec 14 22:37:30 2017 +0000 Replace CanvasResource_Skia with CanvasResource_Bitmap This change refactors the existing CanvasResource_Skia to make it store a StaticBitmapImage instead of an SkImage intenally. This simplifies the gpu mailbox management code by re-using the functionality provided by StaticBitmapImage. It also bring the code closer to unifying OffscreenCanvasResourceProvider with CanvasResourceProvider BUG=788439, 776801 TBR=bajones@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia57a68e1a61763daa158403e258b89b56a82a6f7 Reviewed-on: https://chromium-review.googlesource.com/820251 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#524204} :040000 040000 cf64701c1fa6ef43e5f0db42c4430ac75fe92e01 73aed1adeb81f2c8d433eaf8d881012b82567a74 M third_party
,
Jan 18 2018
Doesn't seem to revert cleanly... Justin, can you take a look? Thanks!
,
Jan 19 2018
,
Jan 22 2018
Am able to repro on kevin with 1000 fish + zoom-in/zoom-out.
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86e1b7f9556ded0dbcd745f079a0cb92610c5f6b commit 86e1b7f9556ded0dbcd745f079a0cb92610c5f6b Author: Justin Novosad <junov@chromium.org> Date: Tue Jan 23 21:23:48 2018 Fix 2D canvas flashing black When CanvasResource was refactored by this CL: https://chromium.googlesource.com/chromium/src/+/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6 We when from using SkImage to using StaticBitmapImage. For tracking texture resources. StaticBitmapImage benefits from a mailbox caching mechanism implemented in GraphicsContext3DUtils, so when the underlying GrTexture object is recycled, GraphicsContext3DUtils retrieves the old mailbox name from its cache. When CanvasResource was transition to use StaticBitmapImage we needed to stop disassociating mailbox names during tear down because it invalidate the mailboxes cached by GraphicsContext3DUtils. The test that verifies that mailbox names are not leaked was modified to expect mailbox disassociation to be triggered by GrTexture destruction rather than CanvasResource destruction. BUG= 796838 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idff59a57a5acee08a7b7573e3b34593aa1938fa5 Reviewed-on: https://chromium-review.googlesource.com/881304 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#531352} [modify] https://crrev.com/86e1b7f9556ded0dbcd745f079a0cb92610c5f6b/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp [modify] https://crrev.com/86e1b7f9556ded0dbcd745f079a0cb92610c5f6b/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp
,
Jan 23 2018
,
Jan 23 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 7 2018
,
Feb 7 2018
The issue still reproduce on M-65
,
Feb 7 2018
,
Feb 7 2018
Put up a cherrypick of this at https://chromium-review.googlesource.com/#/c/chromium/src/+/907208/ If this is good to merge back please land it.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ffbc5859a88276f0c64d2448772f267fd958f6c commit 3ffbc5859a88276f0c64d2448772f267fd958f6c Author: Justin Novosad <junov@chromium.org> Date: Wed Feb 07 18:13:34 2018 Fix 2D canvas flashing black When CanvasResource was refactored by this CL: https://chromium.googlesource.com/chromium/src/+/2e4a432454ac3f04d6c5fa8f17c49ce3026217d6 We when from using SkImage to using StaticBitmapImage. For tracking texture resources. StaticBitmapImage benefits from a mailbox caching mechanism implemented in GraphicsContext3DUtils, so when the underlying GrTexture object is recycled, GraphicsContext3DUtils retrieves the old mailbox name from its cache. When CanvasResource was transition to use StaticBitmapImage we needed to stop disassociating mailbox names during tear down because it invalidate the mailboxes cached by GraphicsContext3DUtils. The test that verifies that mailbox names are not leaked was modified to expect mailbox disassociation to be triggered by GrTexture destruction rather than CanvasResource destruction. BUG= 796838 (cherry picked from commit 86e1b7f9556ded0dbcd745f079a0cb92610c5f6b) Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idff59a57a5acee08a7b7573e3b34593aa1938fa5 Reviewed-on: https://chromium-review.googlesource.com/881304 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531352} Reviewed-on: https://chromium-review.googlesource.com/907208 Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#363} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/3ffbc5859a88276f0c64d2448772f267fd958f6c/third_party/WebKit/Source/platform/graphics/CanvasResource.cpp [modify] https://crrev.com/3ffbc5859a88276f0c64d2448772f267fd958f6c/third_party/WebKit/Source/platform/graphics/CanvasResourceTest.cpp
,
Feb 7 2018
,
Feb 7 2018
,
Feb 12 2018
Why Merge-TBD? I think the work is done here.
,
Feb 12 2018
Issue is fixed and verified with M-65 build 10323.30.0/65.0.3325.65 on kip, daisy and reks
,
Feb 13 2018
Issue 810115 has been merged into this issue.
,
Feb 19 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kainino@chromium.org
, Dec 22 2017Labels: Needs-Bisect