Regression: Checkbox color appears changed then expected and also seen larger in size
Reported by
aiman.an...@etouch.net,
Dec 21 2017
|
|||||
Issue descriptionChrome Version: 65.0.3300.0 (Official Build) (cohort: 63_win_108)dea3d7abb6ccc703942ae522dd2069d70dbd4b68-refs/heads/master@{#525555} (32/64-bit) OS: Win(7,8,10), Linux(14.04 LTS) OS Steps to reproduce: 1. Launch chrome, go to chrome://settings/importData 2. Observe the overlay Actual Result: Checkbox color appears changed then expected and also seen larger in size Expected Result: Checkbox color should be seen as expected and should be proper. This is regression issue broken in ‘M-65’ and and below is the bisect info Using the per-revision bisect providing the bisect results, Good build:65.0.3299.0(Revision:524907) Bad build:65.0.3300.0(Revision:525555) You are probably looking for a change made after 525395 (known good), but no later than 525396 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/831bb7562f3ff585db629f92a16b4c4425d63641..aafc53d5521fee77ac267db150b833a87d057146 Suspect: https://chromium.googlesource.com/chromium/src/+/aafc53d5521fee77ac267db150b833a87d057146 @adpapad:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Will update MAC OS status Thank You!
,
Dec 21 2017
I am able to reproduce this, only with optimize_webui = true. Investigating.
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe4e2daaacfc603d7ec280ed064b934d704450c6 commit fe4e2daaacfc603d7ec280ed064b934d704450c6 Author: Demetrios Papadopoulos <dpapad@chromium.org> Date: Thu Dec 21 22:52:55 2017 Revert "WebUI: Break long style lines, remove addressed TODO." This reverts commit aafc53d5521fee77ac267db150b833a87d057146. Reason for revert: Caused style breakages, that only happen "optimize_webui = true", see crbug.com/796824 and crbug.com/796832 . Original change's description: > WebUI: Break long style lines, remove addressed TODO. > > As of Polymer 1.11.2, breaking lines within style include="..." attributes is > allowed, see [1]. Removing obsolete TODOs. > > [1] https://github.com/Polymer/polymer/pull/4902 > > Bug: None > Change-Id: I0156300cf60ed3d7af76ef755532b69aa0280704 > Reviewed-on: https://chromium-review.googlesource.com/833371 > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525396} TBR=michaelpg@chromium.org,dpapad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 796824 , 796832 Change-Id: I85b9dd80b4fe15748d2339a04400073c9fafca12 Reviewed-on: https://chromium-review.googlesource.com/840802 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#525840} [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/audio_settings.html [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/battery_settings.html [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/device_emulator_pages.html [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/input_device_settings.html [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/settings/internet_page/network_proxy_section.html [modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/settings/settings_shared_css.html
,
Dec 21 2017
Reverted the CL for now. Will make sure this does not happen when I roll it forward again.
,
Jan 2 2018
Update : Retested above issue on Windows(7,8,8.1,10), Linux(14.04 LTS), Mac(10.12.6), (10.13.1) & (10.13.2) OS using latest Canary #65.0.3309.0 and issue is fixed. Now, the color for checkbox on chrome://settings/importData is seen as intended. Kindly review an attached screen-cast. Thank you!
,
Jan 9 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by aiman.an...@etouch.net
, Dec 21 2017