New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Focus get lost on pressing tab key in checkbox of clear browsing data

Reported by shruti.j...@etouch.net, Dec 21 2017

Issue description

Chrome Version:65.0.3300.0 (Official Build) (64-bit) (cohort: Stable)
dea3d7abb6ccc703942ae522dd2069d70dbd4b68-refs/heads/master@{#525555}

OS: Win(7,8,10)and Linux(14.04 LTS).


Steps to reproduce:
1.Launch chrome and Navigate to chrome://settings/clearBrowserData
2.Press tab key and observe.


Actual Result: Focus gets lost in check box after pressing tab key in checkbox.
Expected Result: Focus should stay in check box after pressing tab key in checkbox.

This is regression issue broken in ‘M-65’ and soon inform the bisect info.

Good build-65.0.3299.0
Bad-build-65.0.3300.0
Thank You!







 
Description: Show this description
Cc: ranjitkan@chromium.org rbasuvula@chromium.org nyerramilli@chromium.org
Components: UI>Settings
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)

Kindly refer the Bisect info:
Good build:65.0.3299.0(Revision:524907)
Bad-build:65.0.3300.0(Revision:525555)

You are probably looking for a change made after 525395 (known good), but no lat
er than 525396 (first known bad).
CHANGE LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/831bb7562f3ff585db629f92a16b4c4425d63641..aafc53d5521fee77ac267db150b833a87d057146

Suspect:https://chromium.googlesource.com/chromium/src/+/aafc53d5521fee77ac267db150b833a87d057146

@dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Please refer the attached screen-cast.

Note:Will soon update issue status about MAC OS.

Thank You!
Actuall.mp4
466 KB View Download
Expectedd.mp4
339 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe4e2daaacfc603d7ec280ed064b934d704450c6

commit fe4e2daaacfc603d7ec280ed064b934d704450c6
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Thu Dec 21 22:52:55 2017

Revert "WebUI: Break long style lines, remove addressed TODO."

This reverts commit aafc53d5521fee77ac267db150b833a87d057146.

Reason for revert:
Caused style breakages, that only happen "optimize_webui = true", see  crbug.com/796824  and  crbug.com/796832 .

Original change's description:
> WebUI: Break long style lines, remove addressed TODO.
>
> As of Polymer 1.11.2, breaking lines within style include="..." attributes is
> allowed, see [1]. Removing obsolete TODOs.
>
> [1] https://github.com/Polymer/polymer/pull/4902
>
> Bug: None
> Change-Id: I0156300cf60ed3d7af76ef755532b69aa0280704
> Reviewed-on: https://chromium-review.googlesource.com/833371
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#525396}

TBR=michaelpg@chromium.org,dpapad@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  796824 , 796832 
Change-Id: I85b9dd80b4fe15748d2339a04400073c9fafca12
Reviewed-on: https://chromium-review.googlesource.com/840802
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525840}
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/battery_settings.html
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/device_emulator_pages.html
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/chromeos/emulator/input_device_settings.html
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/fe4e2daaacfc603d7ec280ed064b934d704450c6/chrome/browser/resources/settings/settings_shared_css.html

Comment 4 by dpa...@chromium.org, Dec 21 2017

Status: Fixed (was: Assigned)
Reverted the CL for now. Will make sure this does not happen when I roll it forward again.
Labels: TE-Verified-M65 TE-Verified-65.0.3309.0
Update : 
Retested above issue on Mac(10.12.6, 10.13.2), Windows(7,8,10) and Linux(14.04 LTS) OS using latest Canary #65.0.3309.0 and issue is fixed.Focus appears on check-boxes completely.
Thank you!
Current result.mp4
271 KB View Download
Labels: RegressedIn-65 Target-65 FoundIn-65

Sign in to add a comment