StringDataPipeProducer makes a potentially unnecessary copy |
||
Issue descriptionI want to use StringDataPipeProducer for something that has it's own data string that it owns. This data string could be big. StringDataPipeProducer does a copy of the string if it can't write the whole thing. I would like there to be an option for it to not copy the string and trust that the original StringPiece will be valid until the |callback| is called.
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ecba6153d66d4710d0368ae8ed315a4f04b363f commit 0ecba6153d66d4710d0368ae8ed315a4f04b363f Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Feb 07 20:56:18 2018 [Mojo] Removed string copy requirement from StringDataPipeProducer Bug: 796818 Change-Id: I9955a1bc86404e8c68e373bf572a99192e8f7e4c Reviewed-on: https://chromium-review.googlesource.com/839021 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#535135} [modify] https://crrev.com/0ecba6153d66d4710d0368ae8ed315a4f04b363f/content/browser/file_url_loader_factory.cc [modify] https://crrev.com/0ecba6153d66d4710d0368ae8ed315a4f04b363f/mojo/public/cpp/system/string_data_pipe_producer.cc [modify] https://crrev.com/0ecba6153d66d4710d0368ae8ed315a4f04b363f/mojo/public/cpp/system/string_data_pipe_producer.h [modify] https://crrev.com/0ecba6153d66d4710d0368ae8ed315a4f04b363f/mojo/public/cpp/system/tests/string_data_pipe_producer_unittest.cc
,
Jan 3
|
||
►
Sign in to add a comment |
||
Comment 1 by dmu...@chromium.org
, Dec 21 2017