New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796815 link

Starred by 1 user

Issue metadata

Status: Verified
Merged: issue 796813
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 875109



Sign in to add a comment

Files app touch: need "paste" menu item in the default gear menu

Project Member Reported by yamaguchi@chromium.org, Dec 21 2017

Issue description

Chrome Version: 65.0.3288.0

We've added the three-dot menu button to make the context menu of selected files more accessible for touch UI, during the selection mode.
The gear(three-dots) menu button of the toolbar should also perform as the "context menu of the current folder" while no file is selected.
So it should have "paste" menu item just like the context menu opened by clicking on the blank part of the file list.

Currently users need to workaround by two-finger tap on a blank part of the file list.
 
Cc: weifangsun@chromium.org fukino@chromium.org
Isn't it nicer to open the context menu on the top, when long-pressing an empty area of the folder? I've filed  issue 796813 
Mergedinto: 796813
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
Reopening because  Issue 796813  is about a different way to open context menu.
Status: Started (was: Assigned)
Status: Untriaged (was: Started)
Owner: weifangsun@chromium.org
> Isn't it nicer to open the context menu on the top, when long-pressing an empty area of the folder? I've filed  issue 796813 
This looks reasonable as the backward compatibility without affecting the new touch UI, so we'll do this.
However, I don't think that way is always accessible in all folders. When there are more files than fit in the window (i.e. having a scroll bar) in the list view mode, such "blank part" does not exist.
So I don't think we solely depend on it but need another access way like this Issue.

Here's a pending change to add paste item to the overflow menu. It is pending because the UI design is not confirmed.
https://chromium-review.googlesource.com/c/chromium/src/+/841962
It will look like the attached screenshot.
- Is this overflow menu the right place to add "paste" command?
- If so, should we change the ordering of the menu list and add separator? One of the alternative ideas is having "Paste" the first item in the menu and consist an independent group.
Screenshot 2017-12-25 13:29:20.png
31.9 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77e995d28edc6fb303ceb1d596fdf17b046c3ef6

commit 77e995d28edc6fb303ceb1d596fdf17b046c3ef6
Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Date: Wed Jan 24 09:09:55 2018

Add paste menu item to the gear menu.

Test: browser_tests --gtest_filter=GearMenu*
Bug:  796815 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iab214e1e4e991518e8c8c02a37ebd7a5c93e93f3
Reviewed-on: https://chromium-review.googlesource.com/841962
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531484}
[modify] https://crrev.com/77e995d28edc6fb303ceb1d596fdf17b046c3ef6/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/77e995d28edc6fb303ceb1d596fdf17b046c3ef6/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/77e995d28edc6fb303ceb1d596fdf17b046c3ef6/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/77e995d28edc6fb303ceb1d596fdf17b046c3ef6/ui/file_manager/integration_tests/file_manager/gear_menu.js

Labels: M-65
Owner: yamaguchi@chromium.org
Status: Assigned (was: Untriaged)
yamaguchi@ - Just checking if this fix is planned for M65? Looks like even though we resolved the approach over email, I forgot to update the bug owner properly.
Labels: Merge-Request-65
I would like to merge this to M-65 as it's been planned to fix by M65.
Labels: -M-65 -Merge-Request-65 M-66
Status: Fixed (was: Assigned)
We've decided not to have this patched into M65, but will be shipped with M66.
Cc: yamaguchi@chromium.org mcirimele@chromium.org
 Issue 755111  has been merged into this issue.
Status: Verified (was: Fixed)
Google Chrome	66.0.3352.0 (Official Build) dev (64-bit)
Platform	10431.0.0 (Official Build) dev-channel eve

Blocking: 875109

Sign in to add a comment