New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796813 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Long pressing on an empty area in the folder doesn't open the context menu on the top

Project Member Reported by satorux@chromium.org, Dec 21 2017

Issue description

Chrome Version       : 65.0.3299.0

What steps will reproduce the problem?
1. Launch Files app on a touchscreen device
2. Long press on a file and select Copy
3. Move to a folder
4. Long press on an empty area in the folder

What is the expected result?

The context menu on the top opens and I can paste the file.

What happens instead of that?

The context menu on the top does not open.

- If I long press a file in the folder, the context menu on the top opens and I can paste the file
- Double-tapping the folder open the regular context menu, and I can paste the file too


Please provide any additional information below. Attach a screenshot if
possible.


 
Labels: M-65
Cc: satorux@chromium.org yamaguchi@chromium.org
 Issue 796815  has been merged into this issue.
nit:
>- Double-tapping the folder open the regular context menu, and I can paste the file too
I think "double tapping" here means "touching with two fingers."
Re #3, yes you are right. tapping with two fingers

Comment 5 by mfo...@chromium.org, Dec 21 2017

Components: -Internals>Cast>FileManager Platform>Apps>FileManager
This issue does not seem Cast specific.

Status: Started (was: Assigned)
I think the long-tap should open the context menu near the tapped position instead of the one on the top (=toolbar), because the long-tap originally worked as an alias of right-click. It is also consistent with two-finger tap.
https://chromium-review.googlesource.com/c/chromium/src/+/842326
* How the issue happens
Existing code disables the context menu events triggered by long tap in the file list container, since the time when we introduced touch-specific interactions.
https://chromium-review.googlesource.com/c/chromium/src/+/606068/22/ui/file_manager/file_manager/foreground/js/ui/list_container.js
https://chromium-review.googlesource.com/c/chromium/src/+/625506/8/ui/file_manager/file_manager/foreground/js/ui/list_container.js
The new touch interaction is designed to override the standard behavior of Chrome, by setting special handler and suppressing default behavior of Chrome for some events, like 'contextmenu' event. It was needed, for example, to avoid that long-tap triggers both file selection toggling and the context menu. We didn't treat a long-tap in the padding area specially as we thought context menu by long-tap was not a necessary feature. Now we are changing that behavior.

* How the change 842326 works
The FileTableList is responsible for judging whether the long tap is inside the padding or not.
It then notifies to ListContainer by the custom event when the action should open the context menu, so that 'contextmenu' event right after it is not suppressed.

Cc: mcirimele@chromium.org
yamaguchi@: I think this one needs input from PM and UX. Let's wait for their opinions.

Owner: weifangsun@chromium.org
Status: Assigned (was: Started)
Yes, I have examined how it could be fixed, but anyways I will wait the input by those.
Cc: -yamaguchi@chromium.org
Owner: yamaguchi@chromium.org
Assigning back to yamaguchi@ following up from the discussion via email.
Labels: -M-65 M-66
The original issue is partially resolved by introducing paste command to gear menu ( Issue 796815 ) So I'll leave this to M66.
https://chromium-review.googlesource.com/c/chromium/src/+/842326
Owner: sashab@chromium.org
Just to confirm; the discussion via e-mail agreed that we should show the context menu after long pressing in the folder area, correct?
Yes, that's correct.
Labels: CrOS-FilesApp-Touch
Status: Started (was: Assigned)
Labels: -CrOS-FilesApp-Touch CrOSFilesCategory-Touch
Labels: -M-66 M-67
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4cea81e005e6e3ec5a55b82c916b7f768657066

commit d4cea81e005e6e3ec5a55b82c916b7f768657066
Author: Sasha Morrissey <sashab@chromium.org>
Date: Tue Mar 06 05:48:32 2018

Re-enabled long-press for context menu while not selecting a file

Bug:  796813 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7502e76508bace4f4bfe469e56d2c6aa4c0c166f
Reviewed-on: https://chromium-review.googlesource.com/923462
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541048}
[modify] https://crrev.com/d4cea81e005e6e3ec5a55b82c916b7f768657066/ui/file_manager/file_manager/foreground/js/ui/list_container.js

Status: Fixed (was: Started)

Sign in to add a comment