Site engagement should not be affected by notification grant |
||||
Issue descriptionSite engagement being affected by notification grants creates very broken situations. Since a notification grant is forever, a site will have 5 engagement indefinitely, even if a user never visits it. This led to a weird situation where several origins that used an iframe to request notifications (that I never visit) have 5 engagement forever. This is also a privacy issue since I can't delete this engagement data from my profile without knowing what's causing it. I imagine this will be common for https://chat.google.com/ and https://talkgadget.google.com/. This will become far more prominent and confusing when All Sites launches since it is going to use engagement to decide which sites to show at the top of the list. I don't think engagement should be affected by non-user action signals. If notifications are needed as a data point, they should be queried directly rather than opaquely mixing them into engagement. (Or allow interactions with notifications to naturally flow onto interactions with a site, thus accruing engagement) Originally implemented in Issue 679336
,
Dec 30 2017
FWIW, I'm fine with removing permanent site engagement for sites with the notification permission. I think it would make sense for the notification permission grant to be treated as one-off engagement that decays like everything else. As Dom mentions we originally did it because of some nuances of how push works, but I think just depending on engagement for user interaction with the notifications themselves seems pretty good to me.
,
Jan 2 2018
+1. Another change that helped was counting notification interactions towards Site Engagement.
,
Jan 7 2018
,
Jan 7 2018
Seems like there's generally agreement so far to remove the +5 bonus engagement for notification permission. benwells/raymes: do you have any thoughts to the contrary?
,
Jan 7 2018
No concerns - it makes sense to me to remove the permanent bonus.
,
Jan 7 2018
I'll put up a CL. Thanks all. :)
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89a0c97d71e01146c262c3b3a27d181593485940 commit 89a0c97d71e01146c262c3b3a27d181593485940 Author: Dominick Ng <dominickn@chromium.org> Date: Mon Jan 08 22:59:58 2018 Remove bonus site engagement from notifications. This CL removes the bonus engagement received by origins which have notification permission. The bonus was originally added to ensure push aggregators would have engagement for the Budget API. Since then, interaction with notifications now generate engagement, and this is sufficient for accumluating engagement. This CL means a small change to the important sites code, which previously relied on site engagement to tell if an origin had notification permission. BUG= 796802 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1b4b562039b5c1fe4ed2b420ac01f30b83ea74b7 Reviewed-on: https://chromium-review.googlesource.com/853575 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#527798} [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeTest.java [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/budget_service/budget_manager_browsertest.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/important_sites_util.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/site_engagement_details.mojom [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/site_engagement_score.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/site_engagement_score.h [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/site_engagement_score_unittest.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/site_engagement_service.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/site_engagement_service.h [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/engagement/site_engagement_service_unittest.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/push_messaging/push_messaging_browsertest.cc [modify] https://crrev.com/89a0c97d71e01146c262c3b3a27d181593485940/chrome/browser/resources/engagement/site_engagement.js
,
Jan 8 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dominickn@chromium.org
, Dec 27 2017