The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b3dd6459532fa0dda4a817f901f62c389750a2

commit f5b3dd6459532fa0dda4a817f901f62c389750a2
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Jan 18 06:30:14 2018

Generalize file system provider icons.

Since provided file systems are no longer always backed by
extensions, we can no longer generate icon urls for all of them
in Files app.

This CL moves the icon url generation logic to implementations
of ProviderInterface.

Test: TBD.
Bug:  796800 
Change-Id: I40ea58d608273f7f9b623e3bd2a1814f285c5d00
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/871432
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530075}
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/extensions/file_manager/private_api_util.h
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_manager/volume_manager.h
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/extension_provider.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/extension_provider.h
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/fake_extension_provider.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/fake_extension_provider.h
[add] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/icon_set.cc
[add] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/icon_set.h
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/abort_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/add_watcher_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/configure_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/copy_entry_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/delete_entry_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/execute_action_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/get_actions_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/remove_watcher_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/truncate_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/unmount_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/provider_interface.h
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/registry_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/service.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/service_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/smb_client/smb_provider.cc
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/browser/chromeos/smb_client/smb_provider.h
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/test/data/extensions/api_test/file_browser/mount_test/test.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/test/data/extensions/api_test/file_system_provider/configure/test.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/test/data/extensions/api_test/file_system_provider/mount/test.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/test/data/extensions/api_test/file_system_provider/test_util/test_util.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/chrome/test/data/extensions/api_test/file_system_provider/unmount/test.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/compile_js2.gypi
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/externs/volume_info.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/background/js/volume_info_impl.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/foreground/js/providers_model.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/foreground/js/providers_model_unittest.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/foreground/js/ui/providers_menu.js
[modify] https://crrev.com/f5b3dd6459532fa0dda4a817f901f62c389750a2/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js

<triage> Does the change fix the entire issue, or just a part of the issue?