Deprecate a thin wrapper defined in platform/WaitableEvent.h |
||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/657787#125 > we have a thin wrapper of base::WaitableEvent in platform/WaitableEvent.h and other core/ code use it, but it adds nothing so I think we should just use the base one directly. One more context is that we can't use the wrapper version of WaitableEvent in this CL either as it's passed to/from content/, so we need something, either allowing base:: one or introducing yet another indirection
,
Aug 22
If I understand correctly from https://chromium-review.googlesource.com/c/chromium/src/+/657787#125, new code shouldn't use WaitableEvent and the bug is to migrate exist code over.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f13932a1341005122b5e90059ef526d3fc69835e commit f13932a1341005122b5e90059ef526d3fc69835e Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Aug 22 19:40:09 2018 Clearly deprecate blink::WaitableEvent. The "TODO: Deprecate" was ambiguous. I think the intent is that new code shouldn't use it and the TODO is to migrate existing code. Bug: 796799 Change-Id: I73b135b937d65649ff2f0c5fc99723353065e9bb Reviewed-on: https://chromium-review.googlesource.com/1184136 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#585203} [modify] https://crrev.com/f13932a1341005122b5e90059ef526d3fc69835e/third_party/blink/renderer/platform/waitable_event.h |
||
►
Sign in to add a comment |
||
Comment 1 by horo@chromium.org
, Dec 21 2017