New issue
Advanced search Search tips

Issue 796788 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Feature



Sign in to add a comment

DevTools: rename iPhone 5 preset to iPhone 5/SE

Reported by maya-goo...@sofa.co.jp, Dec 21 2017

Issue description

Chrome Version       : 63.0.3239.108 (Official Build)
OS Version: 6.3

What is the expected result?

Please add "iPhone SE."
Its logical resolution is 320x568 (same as iPhone 5).
iPhone SE is still in production. Please consider to enable it by default.

Please add "iPad Pro 10.5." 
Its logical resolution is 834x1112.

Thanks,
 
If "iPad Pro" and "iPad Pro 10.5" is shown, it may cause confusion about 9.7-inch iPad Pro.
If "iPad Pro 10.5" is added, I think "iPad Pro 12.9" and "iPad Pro 10.5" is better.
Cc: sc00335...@techmahindra.com
Components: Platform>DevTools>Mobile
Labels: -Type-Bug M-65 Needs-Triage-M63 Triaged-ET OS-Linux OS-Mac Type-Feature
Status: Untriaged (was: Unconfirmed)
This issue seems to be feature request. Hence adding Untriaged label for further inputs on this.

Thanks!

Comment 3 by caseq@chromium.org, Dec 28 2017

Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)
Owner: l...@chromium.org

Comment 5 by l...@chromium.org, Dec 29 2017

Status: WontFix (was: Assigned)
Thank you for the request!  We have added presets for some very common mobile devices, but we cannot cover all devices that are in production.

For your case, I would suggest adding custom device presets through DevTools settings:
https://developers.google.com/web/tools/chrome-devtools/device-mode/emulate-mobile-viewports#adding_custom_device_presets

Using this, you can manually add as many custom devices that we have not covered.
Thank you for your suggestion.
> we cannot cover all devices that are in production.
OK, I know custom mobile device setting. I'll add 10.5-inch iPad Pro manually.

I suppose many web designers know that "iPhone 5 equals iPhone SE", "iPhone 6 equals iPhone 7 and iPhone 8" and "iPhone 6 Plus equals iPhone 7 Plus and iPhone 8 Plus" in resolution.
https://github.com/ChromeDevTools/devtools-frontend/commit/e4d55f6ffaf71bd25d6513ca9d2812819c83975b#diff-f5be7af93b06423232948f710ac817aa
Now iPhone 6, iPhone 7 and iPhone 8 were merged into one device setting, and iPhone 6 Plus ,iPhone 7 Plus and iPhone 8 were too.
And iPhone 5 was enabled by default.

I request only rename "iPhone 5" to "iPhone 5/SE".

Thanks,

Comment 7 by l...@chromium.org, Jan 4 2018

Cc: -sc00335...@techmahindra.com
Status: Assigned (was: WontFix)
Summary: DevTools: rename iPhone 5 preset to iPhone 5/SE (was: add devices to "Emulation Devices")
Ah, I see, renaming "iPhone 5" to "iPhone 5/SE" would add clarity.  Sounds like a reasonable request to me, I'll take a look.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba556721ec6da58844382a06d2b6bd941a7fa176

commit ba556721ec6da58844382a06d2b6bd941a7fa176
Author: Erik Luo <luoe@chromium.org>
Date: Sat Jan 06 02:33:48 2018

DevTools: update iphone 5 preset name

The iPhone 5 is no longer in production. The iPhone SE is still
produced and has the same display details as the former.

Bug:  796788 
Change-Id: I2b7cadc678ba6e91fd1549ca6bd028105119dc90
Reviewed-on: https://chromium-review.googlesource.com/853171
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527483}
[modify] https://crrev.com/ba556721ec6da58844382a06d2b6bd941a7fa176/third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json

Comment 9 by l...@chromium.org, Jan 6 2018

Status: Fixed (was: Assigned)
Labels: TE-Verified-M65 TE-Verified-65.0.3314.0
Tested the issue on Windows 10, Mac 10.13.1 and Ubuntu 14.04 using Chrome version M65 - 65.0.3315.0. Now able to see iphone 5/SE instead of iphone 5 . Hence adding TE-Verified label. Attached the screencast for reference.

Thank you!
Labels: -TE-Verified-65.0.3314.0 TE-Verified-65.0.3315.0

Sign in to add a comment