Issue metadata
Sign in to add a comment
|
Skia roll broke layout tests, blocking CQ |
||||||||||||||||||||||
Issue descriptionFailing on all platforms: * fast/webgl/texImage-imageBitmap-from-canvas-resize.html * fast/webgl/texImage-imageBitmap-from-image-resize.html * fast/webgl/texImage-imageBitmap-from-imageData-resize.html * fast/webgl/texImage-imageBitmap-from-offscreen-canvas-resize.html https://ci.chromium.org/p/chromium/g/chromium.webkit/console?numbuilds=200 First failing build on Linux: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/37614 (Difficult to see because the previous build failed tons of layout tests) Almost surely this Skia roll: https://chromium-review.googlesource.com/836413 Nothing is getting through the CQ right now. I'm going to stop the Skia auto-roller and revert back to the last known good version.
,
Dec 21 2017
Test logs: FAIL createImageBitmap(HTMLCanvasElement) resize with pixelated resize quality. assert_true: Test failed expected true got false FAIL createImageBitmap(HTMLCanvasElement) resize with low resize quality. assert_true: Test failed expected true got false FAIL createImageBitmap(HTMLCanvasElement) resize with medium resize quality. assert_true: Test failed expected true got false FAIL createImageBitmap(HTMLCanvasElement) resize with high resize quality. assert_true: Test failed expected true got false https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty/37615/layout-test-results/legacy-results.html
,
Dec 21 2017
I don't know how the original roll: https://chromium-review.googlesource.com/836413 passed the commit queue, but the webkit_layout_tests were green in that run. First failing build on a few builders: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/58381 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/37614 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12/8963 There weren't any obvious collisions between that Skia roll and other CLs that landed in earlier builds: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/37612 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/37613 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/37614
,
Dec 21 2017
,
Dec 21 2017
Roll-back in progress in: https://chromium-review.googlesource.com/838305 Sending this through the CQ to avoid accidentally breaking more stuff.
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6184480ecb5a961cabd588ef174db67b9b019f1c commit 6184480ecb5a961cabd588ef174db67b9b019f1c Author: Kenneth Russell <kbr@chromium.org> Date: Thu Dec 21 03:11:07 2017 Roll back Skia to 0dec3af0. The roll here: https://chromium-review.googlesource.com/836413 caused some layout tests to start failing reliably across multiple platforms. BUG= 796769 TBR=mtklein@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I59ef47aefbfdd7c68b8202e9e63d24117b45c6eb Reviewed-on: https://chromium-review.googlesource.com/838305 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#525576} [modify] https://crrev.com/6184480ecb5a961cabd588ef174db67b9b019f1c/DEPS
,
Dec 21 2017
The rollback has gotten the bots green again. So far: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/40902 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/26833 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12/8975 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/37640 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/8080 We should ideally figure out how the original roll made it through the CQ in the first place. Closing this and filing a follow-on bug to track reopening the Skia auto-roller.
,
Dec 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Dec 21 2017