[SPv2] Some multicol tests crash |
||||
Issue descriptionwebkit_unit_tests: All/PaintPropertyTreeBuilderTest.CompositedUnderMultiColumn/2 and All/PaintPropertyTreeBuilderTest.CompositedUnderMultiColumn/3 layout tests: fast/multicol/composited-layer-will-change.html fast/multicol/hit-test-gap-between-pages-flipped.html fast/multicol/hit-test-gap-between-pages.html fast/multicol/multicol-becomes-paged-fixed-height.html fast/multicol/scrollable-basic.html fast/multicol/scrollbar-taller-than-content-box-freeze.html fast/multicol/scrolling-column-rules.html The crash stack is like: [184411:184411:1220/171025.308316:779054618615:FATAL:GeometryMapper.cpp(256)] Check failed: success. #0 0x000003d1bbbc base::debug::StackTrace::StackTrace() #1 0x000003d34a0c logging::LogMessage::~LogMessage() #2 0x00000469cb6a blink::GeometryMapper::LocalToAncestorClipRect() #3 0x00000569ba5a blink::PaintLayerClipper::CalculateRects() #4 0x00000568f48e blink::PaintLayer::CollectFragmentsForPaint() #5 0x00000569ea86 blink::PaintLayerPainter::PaintLayerContents() #6 0x00000569dfc1 blink::PaintLayerPainter::PaintLayerContentsCompositingAllPhases() #7 0x00000569d72c blink::PaintLayerPainter::Paint() #8 0x0000056a0697 blink::PaintLayerPainter::PaintChildren() #9 0x00000569f45e blink::PaintLayerPainter::PaintLayerContents() #10 0x00000569dfc1 blink::PaintLayerPainter::PaintLayerContentsCompositingAllPhases() #11 0x00000569d72c blink::PaintLayerPainter::Paint() #12 0x0000056a0697 blink::PaintLayerPainter::PaintChildren() #13 0x00000569f45e blink::PaintLayerPainter::PaintLayerContents() #14 0x00000569dfc1 blink::PaintLayerPainter::PaintLayerContentsCompositingAllPhases() #15 0x00000569d72c blink::PaintLayerPainter::Paint() #16 0x00000569d514 blink::PaintLayerPainter::Paint() #17 0x000005668263 blink::FramePainter::PaintContents() #18 0x0000056675e2 blink::FramePainter::Paint() #19 0x000004fc70b5 blink::LocalFrameView::PaintInternal() #20 0x000004fc603b blink::LocalFrameView::PaintTree() It crashes when mapping clip rect from one fragment clip to another fragment clip. We may need to adjust the fragment clip hierarchy to avoid such crashes (or avoid such mapping?).
,
Jan 2 2018
Some fast/pagination tests also crash in SPv175.
,
Jan 16 2018
SPv175 crashes have been fixed by recent SPv175 changes.
,
Oct 10
They no more crash on SPv2.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e85cdf90232fa86ff02643057737c1c2a6fbb4 commit 18e85cdf90232fa86ff02643057737c1c2a6fbb4 Author: Philip Rogers <pdr@chromium.org> Date: Wed Oct 24 17:39:01 2018 [SPV2] Run more fragmented paint property tree builder tests These tests can be run now that SPV2 clips work with fragmentation. The results for CompositedUnderMultiColumn have been updated. Bug: 796768 Change-Id: I3a77348fa7875c076098c0ad4b785b381ca311b9 Reviewed-on: https://chromium-review.googlesource.com/c/1298125 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602382} [modify] https://crrev.com/18e85cdf90232fa86ff02643057737c1c2a6fbb4/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by wangxianzhu@chromium.org
, Dec 21 2017