Issue metadata
Sign in to add a comment
|
Parent account email is shown blank in () for the supervised user |
||||||||||||||||||||||
Issue descriptionChrome & CrOS Version: 10176.22.0, 64.0.3282.41 Devices --> Peppy & Paine What steps will reproduce the problem? (1) Create/Import a supervised user (2) Login in to the supervised user (3) Click on the tray to see the details What is the expected result? Usage & History of this user can be reviewed by the manager (xxx@gmail.com) on chrome.com should be seen. What happens instead? Usage & History of this user can be reviewed by the manager () on chrome.com should be seen. Parent account email is shown blank in () for the supervised user Please find the attached screenshots. This is a regression issue as this was working fine on M63 stable build # 63.0.3239.116 Reproducible on M65 latest build # 65.0.3299.0 as well.
,
Jan 2 2018
Looping in chromium//src/chrome/browser/supervised_user/OWNERS & chromium//src/chrome/browser/chromeos/login/OWNERS to get this assigned correctly.
,
Jan 2 2018
+alemate I wonder whether this is related to https://chromium-review.googlesource.com/c/chromium/src/+/804968, as it is merged to 64.0.3282.16. Could we try revert the CL or verify whether it happens before 64.0.3282.16 ?
,
Jan 2 2018
Unable to reproduce the issue on CrOS10176.8.0/Chrome 64.0.3282.14 - Celes Able to reproduce the issue on 10176.11.0/64.0.3282.22 - Cyan
,
Jan 2 2018
Please look at the issue. https://chromium.googlesource.com/chromium/src/+/ff656a66951fd2aae6f43401d9af98e9cc58c4e8
,
Jan 2 2018
It is probably because the CL caused TraySupervisedUser::OnUserSessionUpdated not capturing |custodian_email_| in [1]. The info is created in SessionControllerClient in [2] and should be sent after the user profile is loaded. [1]: https://cs.chromium.org/chromium/src/ash/system/supervised/tray_supervised_user.cc?rcl=ac34346a864cb50a5fe65fb701b3b09de1867526&l=88 [2]: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/session_controller_client.cc?rcl=19eee98dfd576b4c9fc5b4e59ab2ec41c381cbe4&l=106
,
Jan 2 2018
I have a fix: https://chromium-review.googlesource.com/c/chromium/src/+/848020
,
Jan 2 2018
The supervised/child user session is now created as supervised/child type. There is no user session updated notification after the creation. Hence breaks TraySupervisedUser since it only observes OnUserSessionUpdated. The CL fixes the issue by making TraySupervisedUser observe other user session changes.
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b910d51d757bc376356d333812c0dc595f7a7beb commit b910d51d757bc376356d333812c0dc595f7a7beb Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Jan 04 19:16:48 2018 TraySupervisedUser observe user add/switch TraySupervisedUser should observe user session addition and switch as well as the user session update. Otherwise, it might miss some session info as in http://crbug.com/796758 , where user child info is now only set at user session creation with no user session update followed. Bug: 796758 Change-Id: Ic275ccfa174a21451077e6ec9225901f188e2a63 Reviewed-on: https://chromium-review.googlesource.com/848020 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#527057} [modify] https://crrev.com/b910d51d757bc376356d333812c0dc595f7a7beb/ash/system/supervised/tray_supervised_user.cc [modify] https://crrev.com/b910d51d757bc376356d333812c0dc595f7a7beb/ash/system/supervised/tray_supervised_user.h
,
Jan 4 2018
Please be sure to make a merge request when ready / verified since it's a blocker... Thanks...
,
Jan 4 2018
will do... Waiting for a canary/dev build to verify.
,
Jan 5 2018
Verified in canary build 10282.0.0/65.0.3312.0.
,
Jan 5 2018
Approving merge to M64 Chrome OS.
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b84230a0e79599024c116a8ab6a5f20d53593317 commit b84230a0e79599024c116a8ab6a5f20d53593317 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Jan 05 19:19:45 2018 [Merge M64] TraySupervisedUser observe user add/switch TraySupervisedUser should observe user session addition and switch as well as the user session update. Otherwise, it might miss some session info as in http://crbug.com/796758 , where user child info is now only set at user session creation with no user session update followed. (cherry picked from commit b910d51d757bc376356d333812c0dc595f7a7beb) Bug: 796758 Change-Id: Ic275ccfa174a21451077e6ec9225901f188e2a63 Reviewed-on: https://chromium-review.googlesource.com/848020 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#527057} Reviewed-on: https://chromium-review.googlesource.com/852894 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#420} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/b84230a0e79599024c116a8ab6a5f20d53593317/ash/system/supervised/tray_supervised_user.cc [modify] https://crrev.com/b84230a0e79599024c116a8ab6a5f20d53593317/ash/system/supervised/tray_supervised_user.h
,
Jan 5 2018
,
Jan 8 2018
Verified on Chrome 64.0.3282.79/CrOS 10176.41.0 - Leon |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kbleicher@chromium.org
, Jan 2 2018