New issue
Advanced search Search tips

Issue 796748 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Why does en-AU spell check dictionary map to en-GB?

Project Member Reported by thestig@chromium.org, Dec 21 2017

Issue description

Filing bug on behalf of user "twb" on #chromium.

https://crrev.com/c6e9ccf added a Persian dictionary for Spellcheck, but it also changed the LanguageRegion mapping from "en-AU : en-AU" to "en-AU : en-GB" and it is not obvious why. Is this a bug, or is it done on purpose?
 
Cc: k...@chromium.org rouslan@chromium.org
Cc: hichris...@gmail.com
For a long time we did not have en-AU specific dictionary. This has been fixed in https://crrev.com/a9bac57ce6c9d390a52ebaad3259f5fdb871210e.
So does the mapping need an update then?
Status: Available (was: Unconfirmed)
You're right. It does. Chris: Can you fix the mapping here, please?

https://cs.chromium.org/chromium/src/components/spellcheck/common/spellcheck_common.cc?rcl=c6c5524751517a627fc2934f7f4acb9d26569a76&l=39
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/665277920223f846abd12da9f9df7d8d5e40b1a1

commit 665277920223f846abd12da9f9df7d8d5e40b1a1
Author: Chris Nardi <hichris123@gmail.com>
Date: Wed Jan 24 13:47:31 2018

Update dictionary mapping for en-AU

A standalone dictionary for en-AU was added in
https://crrev.com/6ae8ce1, but the dictionary mapping was never updated.
After this change, the new dictionary will now be pulled for en-AU users
instead of en-GB.

Bug:  796748 
Change-Id: Icae33a393575d77e48024ca14c46b6ae9fd05e0d
Reviewed-on: https://chromium-review.googlesource.com/877108
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531517}
[modify] https://crrev.com/665277920223f846abd12da9f9df7d8d5e40b1a1/components/spellcheck/common/spellcheck_common.cc

Status: Fixed (was: Available)

Sign in to add a comment