New issue
Advanced search Search tips

Issue 796733 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 724392
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Some CSS tests using *pre-installed* Ahem are flaky on Windows

Project Member Reported by robertma@chromium.org, Dec 20 2017

Issue description

This is not the same as  https://crbug.com/507054 , which is about loading Ahem via web font.

Some CSS tests assume Ahem is pre-installed on the system and directly specify Ahem as the font family instead of loading it via @fontface. This should not have any flakiness in theory. Yet somehow these tests are still slightly flaky on Windows. e.g.

external/wpt/css/css-ui/text-overflow-007.html
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fcss%2Fcss-ui%2Ftext-overflow-007

Note: Ahem is loaded to content_shell by  https://cs.chromium.org/chromium/src/content/shell/app/blink_test_platform_support_win.cc?sq=package:chromium&l=33
 
I'm not familiar with the font matching mechanism on Windows. Is it case-sensitive? I think the actual family name of ahem.ttf is Ahem, but the tests use ahem instead.

However, it's flaky, but not always failing... Where's the non-determinism?... 
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a001154ec902b5341ddf0989c205d0b82b78ae8b

commit a001154ec902b5341ddf0989c205d0b82b78ae8b
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Dec 21 17:36:28 2017

Add specific bug for some flaky failures in css-ui tests

Bug:  796733 
Change-Id: Ic53709e6b32cb9d8f24e3ced6749a684b5952201
Reviewed-on: https://chromium-review.googlesource.com/830832
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525728}
[modify] https://crrev.com/a001154ec902b5341ddf0989c205d0b82b78ae8b/third_party/WebKit/LayoutTests/TestExpectations

Mergedinto: 794136
Status: Duplicate (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e30720e61f0306dc4efa540ba89e99889cc4677

commit 7e30720e61f0306dc4efa540ba89e99889cc4677
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed Feb 28 12:22:33 2018

[css-ui] Use "Ahem" instead of "ahem" in tests

"ahem" is causing flakiness on Windows, so this patch
just replaces "ahem" by "Ahem" on css-ui WPT tests.

BUG= 724392 , 796733 

Change-Id: I956e939790319ec956164f34af8c72f109c528ef
Reviewed-on: https://chromium-review.googlesource.com/940133
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#539797}
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/outline-016.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/reference/text-overflow-008-ref.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/reference/text-overflow-013-ref.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-007.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-008.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-010.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-011.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-013.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-014.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-015.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-016.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-017.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-020.html
[modify] https://crrev.com/7e30720e61f0306dc4efa540ba89e99889cc4677/third_party/WebKit/LayoutTests/external/wpt/css/css-ui/text-overflow-023.html

Comment 5 by r...@igalia.com, Feb 28 2018

Mergedinto: -794136 724392

Sign in to add a comment