New issue
Advanced search Search tips

Issue 796669 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 767106
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

webkit-patch rebaseline-cl fails to get finished results when the CL changes description etc.

Project Member Reported by wangxianzhu@chromium.org, Dec 20 2017

Issue description

To reproduce:
1. Create a CL that needs a rebaseline;
2. Run webkit-patch rebaseline-cl
3. Change the CL description (or rebaseline, etc.)
4. After all jobs finish, run webkit-patch rebaseline-cl again.

Expected: step 4 should use the results of finished jobs.

Actual: step 4 schedules new jobs, not using the finished results.

The current result is because gerrit creates a new patch set when CL description is changed. Gerrit is smart to reuse trybot results of previous patch sets for later patch sets created by description change, rebaseline, etc. that don't have actual code changes.

Rebaseline-cl should use the same gerrit rule to reuse trybot results across patch sets.
 
An example is https://chromium-review.googlesource.com/c/chromium/src/+/832941. I have to wait for another round of try jobs though there are available results.
Mergedinto: 767106
Status: Duplicate (was: Available)
Merging with 767106, same issue.

The Gerrit plugin for showing the results has logic for listing the last "non-trivial" patchset. In order to make rebaseline-cl do this, we would want to change git_cl.py in depot tools to find the latest "non-trivial" patchset when requesting results for `git cl try-results`.

Sign in to add a comment