New issue
Advanced search Search tips

Issue 796668 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"external/wpt/longtask-timing/longtask-in-sibling-iframe-crossorigin.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 20 2017

Issue description

"external/wpt/longtask-timing/longtask-in-sibling-iframe-crossorigin.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhleHRlcm5hbC93cHQvbG9uZ3Rhc2stdGltaW5nL2xvbmd0YXNrLWluLXNpYmxpbmctaWZyYW1lLWNyb3Nzb3JpZ2luLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: qyears...@chromium.org
Status: Assigned (was: Untriaged)
Over to qyearsley@

Saw a flake on the Linux Tester:
https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65851
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b301d66985ef8f0f3bdfa65943b02105506525d2

commit b301d66985ef8f0f3bdfa65943b02105506525d2
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Dec 22 18:31:28 2017

Disable longtask-in-sibling-iframe-crossorigin.html

This test flakily times out on all platforms regularly.

TBR=qyearsley@chromium.org

Bug:  796668 
Change-Id: I7412389b460b371c3d53976960d3b39cc40fc4a9
Reviewed-on: https://chromium-review.googlesource.com/842465
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526024}
[modify] https://crrev.com/b301d66985ef8f0f3bdfa65943b02105506525d2/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by mek@chromium.org, Dec 22 2017

Labels: -Sheriff-Chromium
Labels: -Pri-1 Test-Layout Pri-3
Owner: ----
Status: Available (was: Assigned)
Owner: panicker@chromium.org
Status: Assigned (was: Available)
Assigning to panicker@ as per OWNERs file.
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Jan 9 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "external/wpt/longtask-timing/longtask-in-sibling-iframe-crossorigin.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhleHRlcm5hbC93cHQvbG9uZ3Rhc2stdGltaW5nL2xvbmd0YXNrLWluLXNpYmxpbmctaWZyYW1lLWNyb3Nzb3JpZ2luLmh0bWwM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Owner: qyears...@chromium.org
Looks like the wrong test was disabled before?

Fixing here:

https://chromium-review.googlesource.com/c/chromium/src/+/860528

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c77ffb8606a1be317eac0880a9c334cb9346efdb

commit c77ffb8606a1be317eac0880a9c334cb9346efdb
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Jan 10 17:59:07 2018

Disable flaky longtask-in-sibling-iframe-crossorigin

Bug:  796668 
Change-Id: I754ab068e9fa4ed814b96fc69e24c5efc95ded77
TBR: mek,qyearsley
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/860528
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528351}
[modify] https://crrev.com/c77ffb8606a1be317eac0880a9c334cb9346efdb/third_party/WebKit/LayoutTests/TestExpectations

Owner: ----
Status: Available (was: Assigned)
Components: Blink>PerformanceAPIs
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6310ba8bd15b7af935e1426a04caaa65c1214c79

commit 6310ba8bd15b7af935e1426a04caaa65c1214c79
Author: Nicolas Pena <npm@chromium.org>
Date: Fri Jul 13 15:01:26 2018

Update expectations of longtask-timing

The tests were disabled when determined to be flaky (see CLs in the bug below).
The longtask-in-sibling-iframe.html test seems to pass all the time, and the
other is marked as Pass Timeout instead of Skip.

Bug:  796668 
Change-Id: I4d297a0ad1dd5bfac6a6f5d1e0eb0aeb03b65935
Reviewed-on: https://chromium-review.googlesource.com/1135913
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574917}
[modify] https://crrev.com/6310ba8bd15b7af935e1426a04caaa65c1214c79/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Pri-3 Pri-2
Status: Assigned (was: Available)
Owner: npm@chromium.org
Meant to assign to myself.
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f57472f592d43b0cb512047cc35cf4035eb77508

commit f57472f592d43b0cb512047cc35cf4035eb77508
Author: Nicolas Pena <npm@chromium.org>
Date: Mon Jul 16 20:04:28 2018

Make longtask WPT layouttests less flaky

This CL improves tests in external/wpt/longtask-timing by:
* Increasing the length of a longtask from ~51 to ~60 to prevent a
coarse performance.now() granularity from affecting the tests.
* Wrapping the long tasks or iframes containing longtasks inside onload
handlers to ensure that the PerformanceObserver is registered by the
time the longtask is executed.

Test: third_party/blink/tools/run_web_tests external/wpt/longtask-timing
--iterations=1000 did not produce flakes.

Bug:  796668 
Change-Id: Ic2ce59f7d221566f5443da9e9c7d36c7bd7bbe6f
Reviewed-on: https://chromium-review.googlesource.com/1138725
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575396}
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-attributes.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-childiframe-crossorigin.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-childiframe.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-externalscript.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-parentiframe.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-raf.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-sibling-iframe-crossorigin.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-in-sibling-iframe.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/longtask-tojson.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/makelongtask.js
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/raflongtask.js
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/resources/subframe-with-longtask.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/shared-renderer/longtask-in-new-window.html
[modify] https://crrev.com/f57472f592d43b0cb512047cc35cf4035eb77508/third_party/WebKit/LayoutTests/external/wpt/longtask-timing/shared-renderer/resources/frame-with-longtask.html

Status: Fixed (was: Assigned)

Sign in to add a comment