New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796666 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Allow aura shell clients to set frame colors.

Project Member Reported by reve...@chromium.org, Dec 20 2017

Issue description

The aura shell protocol provides an interface to control if a window frame should be visible. However, it doesn't yet provide a request for controlling the colors of the frame. We should add it as it's useful to improve UI integration.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/786d31854a156473e27484e8d9e2c205e01aa1a5

commit 786d31854a156473e27484e8d9e2c205e01aa1a5
Author: David Reveman <reveman@chromium.org>
Date: Wed Dec 20 22:04:33 2017

exo: Add request to set frame colors to aura protocol.

This allows aura shell clients to control the color of the
requested window frame.

Bug:  796666 
Test: xwl-run --frame-color=#00FF00 xterm
Change-Id: Iaee7358fdda660b6b2d43bf46e2c939fed32a5da
Reviewed-on: https://chromium-review.googlesource.com/837601
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525486}
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/shell_surface_base.cc
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/shell_surface_base.h
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/sub_surface.h
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/surface.cc
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/surface.h
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/surface_delegate.h
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/surface_tree_host.h
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/wayland/aura-shell-client-protocol.h
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/wayland/aura-shell-protocol.c
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/wayland/aura-shell-server-protocol.h
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/wayland/protocol/aura-shell.xml
[modify] https://crrev.com/786d31854a156473e27484e8d9e2c205e01aa1a5/components/exo/wayland/server.cc

Status: Fixed (was: Started)
Status: Archived (was: Fixed)

Sign in to add a comment