Per paper-spinner docs at [1]: "The default spinner cycles between four layers of colors; by default they are blue, red, yellow and green. It can be customized to cycle between four different colors. Use <paper-spinner-lite> for single color spinners." In WebUI, we use paper-spinner in several places, and we override the style to show a single color only, see [2]. We should use paper-spinner-lite instead, per the docs suggestion. [1] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner.html?l=22-24 [2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_style_css.html?q=shared_style_css.html&dr&l=11-17
I started https://chromium-review.googlesource.com/c/chromium/src/+/837504 for MD Extensions. Feel free to grab some other part of the code and migrate, but mention which part you are tackling first on this bug, to avoid duplicated work.
FYI, started on md_user_manager/ and media_router/. Remaining references are: chromeos/login/throbber_notice.html settings/people_page/import_data_dialog.html settings/people_page/easy_unlock_turn_off_dialog.html settings/device_page/stylus.html settings/printing_page/cups_add_printer_dialog.html settings/settings_page/settings_subpage.html settings/chrome_cleanup_page/chrome_cleanup_page.html settings/reset_page/reset_profile_dialog.html settings/bluetooth_page/bluetooth_subpage.html settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html
FYI, adressing settings/ directory at https://chromium-review.googlesource.com/c/chromium/src/+/837900.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc5516af2236170ba0ac65a2a3973b2f4e8ffced commit fc5516af2236170ba0ac65a2a3973b2f4e8ffced Author: dpapad <dpapad@chromium.org> Date: Thu Dec 21 00:00:40 2017 MD Extensions: Replace <paper-spinner> with <paper-spinner-lite> Bug: 796661 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id2b220521dc57cd3036dffb9f7491b8ca1823b70 Reviewed-on: https://chromium-review.googlesource.com/837504 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#525520} [modify] https://crrev.com/fc5516af2236170ba0ac65a2a3973b2f4e8ffced/chrome/browser/resources/md_extensions/load_error.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a88f45a62a16561805a9349c5d6ce7387bf70ffd commit a88f45a62a16561805a9349c5d6ce7387bf70ffd Author: dpapad <dpapad@chromium.org> Date: Thu Dec 21 01:13:49 2017 WebUI: Migrate md_user_manager and media_router to paper-spinner-lite. Bug: 796661 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iee6860abf06f81a43eb3612033f5999b5329afda Reviewed-on: https://chromium-review.googlesource.com/837583 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#525547} [modify] https://crrev.com/a88f45a62a16561805a9349c5d6ce7387bf70ffd/chrome/browser/resources/md_user_manager/create_profile.html [modify] https://crrev.com/a88f45a62a16561805a9349c5d6ce7387bf70ffd/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html [modify] https://crrev.com/a88f45a62a16561805a9349c5d6ce7387bf70ffd/chrome/test/data/webui/md_user_manager/create_profile_tests.js [modify] https://crrev.com/a88f45a62a16561805a9349c5d6ce7387bf70ffd/chrome/test/data/webui/media_router/media_router_container_search_tests.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdd7667a6a31104d378c9a679585e894ba4bbed0 commit bdd7667a6a31104d378c9a679585e894ba4bbed0 Author: dpapad <dpapad@chromium.org> Date: Thu Dec 21 03:53:08 2017 WebUI: Migrate remaining usages of paper-spinner. Bug: 796661 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I21294e890e990ed37a511aa901a047bafb702d35 Reviewed-on: https://chromium-review.googlesource.com/838244 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#525590} [modify] https://crrev.com/bdd7667a6a31104d378c9a679585e894ba4bbed0/chrome/browser/resources/chromeos/login/throbber_notice.css [modify] https://crrev.com/bdd7667a6a31104d378c9a679585e894ba4bbed0/chrome/browser/resources/chromeos/login/throbber_notice.html [modify] https://crrev.com/bdd7667a6a31104d378c9a679585e894ba4bbed0/ui/webui/resources/cr_components/certificate_manager/ca_trust_edit_dialog.html [modify] https://crrev.com/bdd7667a6a31104d378c9a679585e894ba4bbed0/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.html [modify] https://crrev.com/bdd7667a6a31104d378c9a679585e894ba4bbed0/ui/webui/resources/cr_elements/shared_style_css.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a1b703645ff8f818e32533cf24c8302ae3f3dbb commit 6a1b703645ff8f818e32533cf24c8302ae3f3dbb Author: dpapad <dpapad@chromium.org> Date: Thu Dec 21 04:18:43 2017 MD Settings: Migrate usage of paper-spinner to paper-spinner-lite. Command used to find usages: ack-grep "paper-spinner" | ack-grep -v "paper-spinner-" This is in preparation of removing <paper-spinner> from third_party/polymer/ folder. Bug: 796661 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie7c997690b8fad37e4f965e0774a5e0d459d0f1d Reviewed-on: https://chromium-review.googlesource.com/837900 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#525600} [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog_tabs.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/device_page/stylus.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/people_page/import_data_dialog.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/search_settings.js [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/browser/resources/settings/settings_page/settings_subpage.html [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/test/data/webui/settings/import_data_dialog_test.js [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/test/data/webui/settings/privacy_page_test.js [modify] https://crrev.com/6a1b703645ff8f818e32533cf24c8302ae3f3dbb/chrome/test/data/webui/settings/search_settings_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7115c43457b34c50c62296d8e28ccab15326ea4 commit f7115c43457b34c50c62296d8e28ccab15326ea4 Author: dpapad <dpapad@chromium.org> Date: Fri Dec 22 02:33:23 2017 Polymer: Remove <paper-spinner> from third_party. All usages have been converted to paper-spinner-lite. Bug: 796661 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2b3ef9bbf59361727ca740bbb80ee1c29f0a11a9 Reviewed-on: https://chromium-review.googlesource.com/840727 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#525908} [modify] https://crrev.com/f7115c43457b34c50c62296d8e28ccab15326ea4/third_party/polymer/v1_0/components-chromium/paper-spinner/BUILD.gn [modify] https://crrev.com/f7115c43457b34c50c62296d8e28ccab15326ea4/third_party/polymer/v1_0/components-chromium/paper-spinner/compiled_resources2.gyp [delete] https://crrev.com/d666fb1f0fffe579ea16a8308015c05d6884ccc1/third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner-extracted.js [delete] https://crrev.com/d666fb1f0fffe579ea16a8308015c05d6884ccc1/third_party/polymer/v1_0/components-chromium/paper-spinner/paper-spinner.html [modify] https://crrev.com/f7115c43457b34c50c62296d8e28ccab15326ea4/third_party/polymer/v1_0/rsync_exclude.txt [modify] https://crrev.com/f7115c43457b34c50c62296d8e28ccab15326ea4/ui/webui/resources/polymer_resources.grdp
Comment 1 by dpa...@chromium.org
, Dec 20 2017