[meta] Fix some event-targeting issues in oopif |
||||||||||||||||
Issue descriptionTo fix some of the event-targeting issues with oopif, we are going to use mojom.InputTargetClient in some cases.
,
Dec 20 2017
,
Dec 20 2017
,
Dec 20 2017
,
Dec 20 2017
,
Dec 20 2017
,
Dec 20 2017
,
Dec 20 2017
,
Jan 5 2018
,
Jan 5 2018
,
Jan 5 2018
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b0a69b5dbaca8c92d037e22016bc398b155891a commit 9b0a69b5dbaca8c92d037e22016bc398b155891a Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Jan 08 03:23:22 2018 oopif events: Merge hit-testing impls for all platforms into one. The draw-quad-based hit-testing code was implemented separately for the aura, mac, and android platforms. But the code is essentially the same. So unify the implementation in base RenderWidgetHostViewBase class, so that all platforms can use the same code. BUG= 796651 Change-Id: I3927775073f5b608e88ced5c519f75e0ef1494db Reviewed-on: https://chromium-review.googlesource.com/852807 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#527560} [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/delegated_frame_host.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/delegated_frame_host.h [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_android.h [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_base.h [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/public/test/browser_test_utils.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/test/test_render_view_host.cc [modify] https://crrev.com/9b0a69b5dbaca8c92d037e22016bc398b155891a/content/test/test_render_view_host.h
,
Jan 9 2018
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89122ef0bd79bc79174e9ee50f622dd9d24200de commit 89122ef0bd79bc79174e9ee50f622dd9d24200de Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Wed Jan 10 19:45:03 2018 oopif events: Improve some of the hit-testing related tests. . Code unification for some tests that involve dispatching a mouse-down event to a view at a certain location, and validating that the event reaches the desired target view at the desired location. . Add a browser-test for layer squashing: if layer-squashing causes parts of a layer in the embedder to overlap the oopif, the events on top of that layer should still reach the oopif. . Add a browser-test for watermarking: if a translucent div on the main page is overlapping the oopif, with pointer-events: none, then the oopif should receive events correctly. BUG= 796651 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idbc2bc793584874d4fc8aebca78e32669a492826 Reviewed-on: https://chromium-review.googlesource.com/853699 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#528387} [modify] https://crrev.com/89122ef0bd79bc79174e9ee50f622dd9d24200de/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/89122ef0bd79bc79174e9ee50f622dd9d24200de/content/browser/site_per_process_browsertest.cc [add] https://crrev.com/89122ef0bd79bc79174e9ee50f622dd9d24200de/content/test/data/frame_tree/oopif_hit_test_layer_squashing.html [add] https://crrev.com/89122ef0bd79bc79174e9ee50f622dd9d24200de/content/test/data/frame_tree/oopif_hit_test_watermark.html [modify] https://crrev.com/89122ef0bd79bc79174e9ee50f622dd9d24200de/testing/buildbot/filters/viz.content_browsertests.filter
,
Jan 11 2018
,
Jan 11 2018
,
Feb 5 2018
sadrul@: Can this be marked fixed now? I see all the blocking bugs are closed.
,
Feb 5 2018
,
Feb 5 2018
This can now be fixed, yep!
,
Feb 6 2018
Sadrul, do we have a bug tracking the full adoption of Viz hit testing for OOPIFs? I can file one if not.
,
Feb 6 2018
The full viz-hitesting with OOP-D is issue 672311 For non-OOPD, there are some relevant bugs: issue 805581 , issue 806144 , issue 732399 etc. It would make sense to create a meta-bug for viz-assisted hit-test in content without OOP-D with these as blocking bugs.
,
Feb 6 2018
I found an existing bug that fits the description: issue 780279. |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by sadrul@chromium.org
, Dec 20 2017