New issue
Advanced search Search tips

Issue 796650 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD Extensions] "Errors" button only shows up after refreshing the page

Project Member Reported by dpa...@chromium.org, Dec 20 2017

Issue description

Repro steps (see screencast too):

1) Open chrome://extensions in non-dev mode.
2) Turn on dev-mode from the toolbar.

Expected
"Errors" buttons for any extension that has errors should immediately show up.

Actual
"Errors" buttons do not show up, until page is refreshed.

Similar behavior is observed for the reverse direction (turning off dev mode should hide "errors" buttons).
 
errors_button_needs_refresh.mp4
1.1 MB View Download

Comment 1 by dpa...@chromium.org, Dec 20 2017

Cc: rdevlin....@chromium.org

Comment 2 by dpa...@chromium.org, Dec 20 2017

Just to clarify, I am reproducing this with --disable-error-console flag. Did not try without it.

Comment 3 by dpa...@chromium.org, Dec 20 2017

Also attaching the previous UI's behavior for reference.
previous_ui_behavior.mp4
1.1 MB View Download

Comment 4 by dpa...@chromium.org, Feb 26 2018

Cc: aee@chromium.org

Comment 5 by aee@chromium.org, Feb 27 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Assigned (was: Available)

Comment 6 by aee@chromium.org, Feb 27 2018

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1ea193294955a0b91a2d3b2b70f36ad2d29e059

commit b1ea193294955a0b91a2d3b2b70f36ad2d29e059
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Mar 06 21:56:12 2018

MD Extensions: update extensions when dev mode toggled

Bug:  796650 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1dc50ba6eb8e7b2f01992fdcee5ade2d7c6f35e1
Reviewed-on: https://chromium-review.googlesource.com/940432
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541210}
[modify] https://crrev.com/b1ea193294955a0b91a2d3b2b70f36ad2d29e059/chrome/browser/extensions/api/developer_private/developer_private_api.cc

Comment 8 by aee@chromium.org, Mar 6 2018

Status: Fixed (was: Started)
Labels: TE-Verified-M67 TE-Verified-67.0.3364.0
Able to reproduce the issue on chrome build without fix
Verified the fix on Mac 10.12.6, Windows-10, Ubuntu 14.04 on Chrome version #67.0.3364.0 as per the comment#0
Attaching screen cast for reference.
Observed "Errors buttons immediately for any extension that has errors"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
796650.ogv
2.1 MB View Download

Sign in to add a comment