New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 796648 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 796651



Sign in to add a comment

Update OOPIF hit-testing to return confidence level

Project Member Reported by sadrul@chromium.org, Dec 20 2017

Issue description

It is necessary to update the existing hit-testing code for OOPIF to return the confidence of the hit-test result. For some hit-test, it can return a RenderWidgetHostViewBase with low-confidence, which means the targeting logic should then query for the correct target to that RenderWidgetHostViewBase.
 
Components: Internals>Sandbox>SiteIsolation

Comment 2 by sadrul@chromium.org, Dec 20 2017

Blocking: 796651
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/772561ba831fa2ca15e0da4b34b0fcd977792d31

commit 772561ba831fa2ca15e0da4b34b0fcd977792d31
Author: Ken Buchanan <kenrb@chromium.org>
Date: Fri Dec 22 16:15:23 2017

Browser quad-based hit testing returns confidence level

This CL adds an output bool to the quad-based hit testing APIs to
SurfaceHitTest. When the bool is true, it means that there is reduced
confidence in the hit test result being returned, and the caller should
invoke InputTargetClient to perform an asynchronous hit test in the
renderer before routing a given input event.

Bug:  796648 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I5d5f4bf18977a85c5e4d7f4c4291a4ec89bca70f
Reviewed-on: https://chromium-review.googlesource.com/840644
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526003}
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/components/viz/service/surfaces/surface_hittest.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/components/viz/service/surfaces/surface_hittest.h
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/components/viz/service/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_input_event_router_unittest.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/772561ba831fa2ca15e0da4b34b0fcd977792d31/content/browser/renderer_host/render_widget_host_view_mac.mm

Comment 5 by kenrb@chromium.org, Dec 22 2017

Status: Fixed (was: Started)

Sign in to add a comment