Change tricium (and buildbucket) plugin to have html and html-import loading |
||
Issue descriptionBecause buildbucket and tricium involve project-specific config, they cannot be entirely html-based plugins currently... but we can still add a main .html file entry point that loads the custom element via html imports: Context: see bug 788815 Related documentation: https://gerrit-review.googlesource.com/Documentation/pg-plugin-migration.html#migration
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/tricium/+/cf1d567a163dc99c27a15ee95a85b9dce257a258 commit cf1d567a163dc99c27a15ee95a85b9dce257a258 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Mon Feb 05 22:42:33 2018 Change entry point for Tricium to tricium.html It turns out that "web UI plugins" entry points can be .html files. The advantage of this way is that the custom element(s) can be loaded via HTML import. Bug: 796638 Change-Id: I4b0bcab6f7738a61f15bafb56ddbb78060897dff Reviewed-on: https://chromium-review.googlesource.com/895053 Reviewed-by: Aaron Gable <agable@chromium.org> [add] https://crrev.com/cf1d567a163dc99c27a15ee95a85b9dce257a258/src/main/resources/static/tricium.html [delete] https://crrev.com/3b01e924a27201d6f0e43247530c8cdf00d7b7b7/src/main/resources/static/tricium.js [modify] https://crrev.com/cf1d567a163dc99c27a15ee95a85b9dce257a258/src/main/java/com/googlesource/chromium/plugins/tricium/TriciumModule.java
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/30693e7e421ffac4eafdb7fd7b42ea033c7ce309 commit 30693e7e421ffac4eafdb7fd7b42ea033c7ce309 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Feb 06 16:17:54 2018 Change entry point for Buildbucket plugin to buildbucket.html Advantage: We can load the cr-buildbucket-view element via HTML import instead of Polymer.Base.importHref. Related CL for Tricium: https://crrev.com/c/895053 Bug: 796638 Change-Id: Ie2bcb1c0d66ef950c17fab3fa77be3791fd4a704 Reviewed-on: https://chromium-review.googlesource.com/895904 Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> [add] https://crrev.com/30693e7e421ffac4eafdb7fd7b42ea033c7ce309/src/main/resources/static/buildbucket.html [modify] https://crrev.com/30693e7e421ffac4eafdb7fd7b42ea033c7ce309/src/main/java/com/googlesource/chromium/plugins/buildbucket/BuildBucketModule.java [delete] https://crrev.com/d575eaf88b5ce1344e2817cb3e14292a49347925/src/main/resources/static/buildbucket.js
,
Feb 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Jan 31 2018Status: Assigned (was: Available)