iOS recipes depend on a different version of swarming client than everything else |
||||||
Issue descriptionCurrently they use the "build/swarming_client" module, and are pinned to "refs/heads/stable", which is wildly out of date and (AFAICT) only used/updated by iOS recipes. This leads to bugs like https://bugs.chromium.org/p/chromium/issues/detail?id=793168 where a new client rolls, and everything except for iOS gets it. IIUC, iOS is now actually a checkout of chromium, so it should be able to use chromium's version of the swarming client?
,
Dec 20 2017
I suppose, it's just a matter of removing two lines at https://chromium.googlesource.com/chromium/tools/build/+/b79b2fcd76dbab3a4eceae494384ed96f7b0cb42/scripts/slave/recipe_modules/ios/api.py#498 ? +smut@ - any historical reason we still have it?
,
Dec 20 2017
will the real smut@ please stand up? :)
,
Dec 20 2017
I don't think there's any reason other than I never bothered to change it. I did switch to the isolate go client in chromium/src as part of another bug. See https://crbug.com/685882#c13 for an issue we encountered there. There may be a similar quirk with the swarming go client, I haven't investigated it. Note also that you can't do a straight client swap upstream without first ensuring it works downstream. Downstream we compile on one builder, then upload a tarball to be downloaded by other builders which trigger tasks and collect results. Those triggered builders have no chromium/src checkout of their own, so the swarming go client from chromium/src would need to be provided in the tarball.
,
Dec 21 2017
Thanks for the info! I'll look into this bug likely in Q1, will keep it available in the meantime.
,
Jul 26
,
Jul 26
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bpastene@chromium.org
, Dec 20 2017Labels: OS-iOS