New issue
Advanced search Search tips

Issue 796621 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

[Android] Unify the way of changing preference

Reported by joey...@amazon.com, Dec 20 2017

Issue description

Chrome Version       : canary (65+)
URLs (if applicable) : N/A

With the way the MainPreferences is currently designed, any change that may missing preferences is not handled gracefully and can cause a crash. 

I would like a propose an approach of  unifying the way of changing preference because I think it would be better and safer for users changing preferences. I have attached the diff of the CL in this email. 
    
This CL unifies the way of chaning preference by adding a common method named "changePreference". In this way, the program can tolerate missing prefrence by design, rather than adding a null pointer for some preference

 
commit_diff.txt
7.5 KB View Download
Labels: OS-Android
Components: Internals>Preferences
Labels: -Type-Bug Needs-triage-Mobile Triaged-Mobile Type-Feature

Comment 4 by joey...@amazon.com, Jan 18 2018

The CL has already been pushed back. We could simply discard this crbug ~
Status: WontFix (was: Unconfirmed)
Closing this issue as per C#4.

Thanks!

Sign in to add a comment