[Android] Unify the way of changing preference
Reported by
joey...@amazon.com,
Dec 20 2017
|
||||
Issue description
Chrome Version : canary (65+)
URLs (if applicable) : N/A
With the way the MainPreferences is currently designed, any change that may missing preferences is not handled gracefully and can cause a crash.
I would like a propose an approach of unifying the way of changing preference because I think it would be better and safer for users changing preferences. I have attached the diff of the CL in this email.
This CL unifies the way of chaning preference by adding a common method named "changePreference". In this way, the program can tolerate missing prefrence by design, rather than adding a null pointer for some preference
,
Dec 21 2017
,
Jan 18 2018
,
Jan 18 2018
The CL has already been pushed back. We could simply discard this crbug ~
,
Jan 18 2018
Closing this issue as per C#4. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by joey...@amazon.com
, Dec 20 2017